Chromium Code Reviews
DescriptionDon't update column position in StyleDidChange.
StyleDidChange set the first column position to the horizontal border
spacing value regardless of whether this value changed or not.
I am not familiar with how table layout works in Blink and haven't
debugged this extensively, but when we re-layout a table cell because
it has out-of-flow content which needs layout, the first effective
column position is set wrongly. It gets its initial value from the line
removed in this CL by a style recalc on the table element prior to the
re-layout, which is the h_spacing_, but the spacing is subtracted once
more in http://bit.ly/2pBB7x1
R=eae@chromium.org,mstensho@opera.com
BUG=716006
Review-Url: https://codereview.chromium.org/2855853002
Cr-Commit-Position: refs/heads/master@{#468920}
(cherry picked from commit d3c625b0b03346472e45dc1fda33d35b1d40efd3)
Review-Url: https://codereview.chromium.org/2867903002 .
Cr-Commit-Position: refs/branch-heads/3071@{#464}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/cd42d9d7807a142fad25e3697fb711dc4f792e7d
Patch Set 1 #
Messages
Total messages: 3 (1 generated)
|
||||||||||||||||||||||||||||