Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h

Issue 2867883003: [CSS Typed OM] Delete obsolete number and length classes from Typed OM (Closed)
Patch Set: Update failing LayoutTests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h b/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h
index 0d4c10d5a0c6f24d24b32f49e5cba0e794792a3e..f90a1f63cdf6af053d56944bc45bd1f287667a1f 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h
@@ -52,7 +52,12 @@ class CORE_EXPORT CSSStyleValue
virtual const CSSValue* ToCSSValueWithProperty(CSSPropertyID) const {
return ToCSSValue();
}
- virtual String cssText() const { return ToCSSValue()->CssText(); }
+ virtual String cssText() const {
+ const CSSValue* result = ToCSSValue();
+ // TODO(meade): Remove this once all the number and length types are
+ // rewritten.
+ return result ? result->CssText() : "";
+ }
DEFINE_INLINE_VIRTUAL_TRACE() {}

Powered by Google App Engine
This is Rietveld 408576698