Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2867853002: Make the new WebUI's code handle all webui schemes, instead of just chrome://. (Closed)

Created:
3 years, 7 months ago by jam
Modified:
3 years, 7 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, wjmaclean, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, Randy Smith (Not in Mondays), darin-cc_chromium.org, loading-reviews_chromium.org, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the new WebUI's code handle all webui schemes, instead of just chrome://. The use case is to get the embedder specified schemes. This makes the NTP work. BUG=717714 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2867853002 Cr-Commit-Position: refs/heads/master@{#470207} Committed: https://chromium.googlesource.com/chromium/src/+/1a97290bbc1c6d83e4b7f9d84bd208a28acde4a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -24 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M content/browser/loader/navigation_url_loader_network_service.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 chunk +4 lines, -15 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jam
3 years, 7 months ago (2017-05-08 20:56:08 UTC) #5
yzshen1
lgtm
3 years, 7 months ago (2017-05-08 21:06:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867853002/1
3 years, 7 months ago (2017-05-08 21:14:11 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 04:31:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a97290bbc1c6d83e4b7f9d84bd2...

Powered by Google App Engine
This is Rietveld 408576698