Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2867823002: [Mac] Hide bookmark bar empty view by default (Closed)

Created:
3 years, 7 months ago by lgrey
Modified:
3 years, 7 months ago
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Hide bookmark bar empty view by default This is a speculative fix for crbug.com/714407, specifically the post-refactor manifestation in #10. Speculative because I can't repro. BUG=714407 Review-Url: https://codereview.chromium.org/2867823002 Cr-Commit-Position: refs/heads/master@{#470367} Committed: https://chromium.googlesource.com/chromium/src/+/777cb457cb9989f53d135239d36196a41835b6a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
lgrey
PTAL :)
3 years, 7 months ago (2017-05-08 18:16:45 UTC) #2
Sidney San Martín
lgtm
3 years, 7 months ago (2017-05-08 19:42:04 UTC) #3
lgrey
Thanks! +Elly for OWNERS
3 years, 7 months ago (2017-05-08 19:47:09 UTC) #7
Elly Fong-Jones
lgtm
3 years, 7 months ago (2017-05-09 17:02:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867823002/1
3 years, 7 months ago (2017-05-09 17:07:02 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 17:35:10 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/777cb457cb9989f53d135239d361...

Powered by Google App Engine
This is Rietveld 408576698