Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 2867813002: WebVR: fix initial vsync (Closed)

Created:
3 years, 7 months ago by klausw
Modified:
3 years, 7 months ago
Reviewers:
bajones, ddorwin
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

WebVR: fix initial vsync Applications sometimes use window.rAF while not presenting, then switch to vrDisplay.rAF after presentation starts. Depending on the animation loop's timing, this can cause a race condition where presentation has been started but there's no vrDisplay.rAF pending yet. Ensure there's at least vsync being processed after presentation starts so that a queued window.rAF can run and schedule a vrDisplay.rAF. BUG=711789 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2848483003 Cr-Commit-Position: refs/heads/master@{#468167} (cherry picked from commit 262e77a72493e36e8006aeeba1c7497a42ee5ad9) Review-Url: https://codereview.chromium.org/2867813002 Cr-Commit-Position: refs/branch-heads/3071@{#454} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/83bc6712b5b740815f9b24dd10934656683cd5de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -8 lines) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 11 chunks +51 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
klausw
(Requesting committer approval for merge)
3 years, 7 months ago (2017-05-08 17:51:15 UTC) #2
ddorwin
merge LGTM
3 years, 7 months ago (2017-05-08 18:44:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867813002/1
3 years, 7 months ago (2017-05-08 18:47:06 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 7 months ago (2017-05-08 18:47:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867813002/1
3 years, 7 months ago (2017-05-08 18:48:42 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 18:50:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/83bc6712b5b740815f9b24dd1093...

Powered by Google App Engine
This is Rietveld 408576698