Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2867803002: Add a metric to record http response code for download requests. (Closed)

Created:
3 years, 7 months ago by xingliu
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Add a metric to record http response code for download requests. Currently we notice an issue according to metric data that parallel download feature has a higher SERVER_FAIL interruption type. we would like to know more details about the http response code from the server to analyze the cause. This metric only applies to download requests and will also be helpful to track general download system health. BUG=718465 Review-Url: https://codereview.chromium.org/2862743002 Cr-Commit-Position: refs/heads/master@{#469888} (cherry picked from commit 503e20c58c8fdae480d5e7bbc538365f17e32fa1) Review-Url: https://codereview.chromium.org/2867803002 . Cr-Commit-Position: refs/branch-heads/3071@{#449} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/49b3271814acb74884e3781628c155775b7f7a0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M content/browser/download/download_request_core.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/download/download_stats.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/download/download_stats.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xingliu
3 years, 7 months ago (2017-05-08 16:51:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
49b3271814acb74884e3781628c155775b7f7a0a.

Powered by Google App Engine
This is Rietveld 408576698