Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 2867783003: DevTools: move IsolatedFileSystem/IsolatedFileSystemManager into persistence/ (Closed)

Created:
3 years, 7 months ago by lushnikov
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move IsolatedFileSystem/IsolatedFileSystemManager into persistence/ This patch moves IsoltaedFileSystem/IsolatedFileSystemManager into persistence/ module since they actually belong to it. BUG=649837 Review-Url: https://codereview.chromium.org/2867783003 Cr-Commit-Position: refs/heads/master@{#470837} Committed: https://chromium.googlesource.com/chromium/src/+/1d43d5f0b13defdc9f637a765a235740c8ef1259

Patch Set 1 #

Patch Set 2 : fix order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -1021 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-in-files.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/file-system-mapping.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/file-system-project.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/EditFileSystemView.js View 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/FileSystemMapping.js View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js View 8 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/persistence/IsolatedFileSystem.js View 25 chunks +36 lines, -36 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/persistence/IsolatedFileSystemManager.js View 12 chunks +28 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/WorkspaceSettingsTab.js View 6 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/module.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystem.js View 1 chunk +0 lines, -576 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js View 1 chunk +0 lines, -321 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/module.json View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (16 generated)
lushnikov
please, take a look
3 years, 7 months ago (2017-05-09 00:40:22 UTC) #2
dgozman
lgtm
3 years, 7 months ago (2017-05-09 21:57:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867783003/20001
3 years, 7 months ago (2017-05-09 22:19:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 00:22:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867783003/20001
3 years, 7 months ago (2017-05-10 01:28:31 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 03:31:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867783003/20001
3 years, 7 months ago (2017-05-10 18:18:40 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450479)
3 years, 7 months ago (2017-05-10 20:46:02 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867783003/20001
3 years, 7 months ago (2017-05-11 03:19:09 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/450589)
3 years, 7 months ago (2017-05-11 04:26:00 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867783003/20001
3 years, 7 months ago (2017-05-11 04:39:43 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 06:05:40 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1d43d5f0b13defdc9f637a765a23...

Powered by Google App Engine
This is Rietveld 408576698