Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2867773002:
Add a missing include that broke the M59 beta build. (Closed)
|
Created:
3 years, 7 months ago by Sigurður Ásgeirsson Modified:
3 years, 7 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a missing include that broke the M59 beta build.
BUG=718975, 682299
Review-Url: https://codereview.chromium.org/2864463005 .
Cr-Original-Commit-Position: refs/branch-heads/3071@{#424}
Cr-Original-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Review-Url: https://codereview.chromium.org/2867773002
Cr-Commit-Position: refs/heads/master@{#470383}
Committed: https://chromium.googlesource.com/chromium/src/+/8e81b8169945aadb5b2ce55577d1979ce37a4add
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
Description was changed from ========== Fix build break due to missing include. BUG=718975,682299 TBR=pkasting@chromium.org Review-Url: https://codereview.chromium.org/2864463005 . Cr-Commit-Position: refs/branch-heads/3071@{#424} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} ========== to ========== Add a missing include that broke the M59 beta build. BUG=718975,682299 Review-Url: https://codereview.chromium.org/2864463005 . Cr-Commit-Position: refs/branch-heads/3071@{#424} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} ==========
siggi@chromium.org changed reviewers: + finnur@chromium.org - pkasting@chromium.org
Hey Finnur, this is cherry-picked from the 3071 branch, where it was necessary to fix a build break. Siggi
The CQ bit was checked by siggi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by siggi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
siggi@chromium.org changed reviewers: + pkasting@chromium.org
Ooops - I thought Finnur was owner there. Peter for OWNERS, pretty please?
LGTM. Feel free to TBR this sort of thing.
The CQ bit was checked by siggi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494352041944500, "parent_rev":
"690997683fffaf201782981ab91701653a0a6a90", "commit_rev":
"8e81b8169945aadb5b2ce55577d1979ce37a4add"}
Message was sent while issue was closed.
Description was changed from ========== Add a missing include that broke the M59 beta build. BUG=718975,682299 Review-Url: https://codereview.chromium.org/2864463005 . Cr-Commit-Position: refs/branch-heads/3071@{#424} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} ========== to ========== Add a missing include that broke the M59 beta build. BUG=718975,682299 Review-Url: https://codereview.chromium.org/2864463005 . Cr-Original-Commit-Position: refs/branch-heads/3071@{#424} Cr-Original-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Review-Url: https://codereview.chromium.org/2867773002 Cr-Commit-Position: refs/heads/master@{#470383} Committed: https://chromium.googlesource.com/chromium/src/+/8e81b8169945aadb5b2ce55577d1... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8e81b8169945aadb5b2ce55577d1... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
