Use OnceCallback on Mojo interfaces in //components/password_manager

Use OnceCallback on Mojo interfaces in //components/password_manager

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//components/password_manager starts using base::OnceCallback instead
of base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018
Review-Url: https://codereview.chromium.org/2867743002
Cr-Commit-Position: refs/heads/master@{#470294}
Committed: https://chromium.googlesource.com/chromium/src/+/e97ac8b97fca517c76bf5345611a47007dc2c486

[tzik, 2017-05-08 09:04:33]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 09:05:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 10:45:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 10:45:37]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-05-09 08:46:41]

Description was changed from

==========
Use OnceCallback on Mojo interfaces in //components/password_manager
==========

to

==========
Use OnceCallback on Mojo interfaces in //components/password_manager

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//components/password_manager starts using base::OnceCallback instead
of base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018
==========

[tzik, 2017-05-09 08:47:03]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 08:47:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-05-09 08:47:44]

Description was changed from

==========
Use OnceCallback on Mojo interfaces in //components/password_manager

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//components/password_manager starts using base::OnceCallback instead
of base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018
==========

to

==========
Use OnceCallback on Mojo interfaces in //components/password_manager

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//components/password_manager starts using base::OnceCallback instead
of base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018
==========

[tzik, 2017-05-09 08:47:44]

tzik@chromium.org changed reviewers:
+ engedy@chromium.org

[engedy, 2017-05-09 09:01:55]

LGTM, thanks!

[tzik, 2017-05-09 09:06:07]

On 2017/05/09 09:01:55, engedy wrote:
> LGTM, thanks!

Thanks for reviewing!

[commit-bot: I haz the power, 2017-05-09 09:43:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 09:43:15]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tzik, 2017-05-09 10:57:54]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2017-05-09 10:58:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 12:53:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494327474467950,
"parent_rev": "d3195585a8ff4e75fdf4a99270e4f945473e69cb", "commit_rev":
"e97ac8b97fca517c76bf5345611a47007dc2c486"}

[commit-bot: I haz the power, 2017-05-09 12:53:18]

Description was changed from

==========
Use OnceCallback on Mojo interfaces in //components/password_manager

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//components/password_manager starts using base::OnceCallback instead
of base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018
==========

to

==========
Use OnceCallback on Mojo interfaces in //components/password_manager

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//components/password_manager starts using base::OnceCallback instead
of base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018

Review-Url: https://codereview.chromium.org/2867743002
Cr-Commit-Position: refs/heads/master@{#470294}
Committed:
https://chromium.googlesource.com/chromium/src/+/e97ac8b97fca517c76bf5345611a...
==========

[commit-bot: I haz the power, 2017-05-09 12:53:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e97ac8b97fca517c76bf5345611a...