Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2867723002: Use OnceCallback on Mojo interfaces in //components/chrome_cleaner (Closed)

Created:
3 years, 7 months ago by tzik
Modified:
3 years, 7 months ago
Reviewers:
robertshield
CC:
chromium-reviews, vakh+watch_chromium.org, joenotcharles+watch_chromium.org, grt+watch_chromium.org, timvolodine, csharp+watch_chromium.org, alito+watch_chromium.org, ftirelo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use OnceCallback on Mojo interfaces in //components/chrome_cleaner This CL flips `use_once_calback` flag on the Mojo code generator, and fixes all compile errors after it. After this CL, Mojo interfaces in //components/chrome_cleaner starts using base::OnceCallback instead of base::Callback on its return value handling. The migration recipe was: - Convert pass-by-ref callback objects to pass-by-value. - Use std::move() to forward it to other consumer, or to invoke it with Callback::Run(). - Handle wherever copies are required manually. - Check if the conversion doesn't change the semantics. As the transfer and invocation clobber the callback object, care about use-after-move. It's considered safe to consume almost scoped-out callback. BUG=714018 Review-Url: https://codereview.chromium.org/2867723002 Cr-Commit-Position: refs/heads/master@{#470322} Committed: https://chromium.googlesource.com/chromium/src/+/5fa4456aa172ddb1dd6bb47036786bb94375fd62

Patch Set 1 #

Patch Set 2 : rebase. +#include. fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/chrome_cleaner/srt_fetcher_browsertest_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/chrome_cleaner/public/interfaces/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
tzik
PTAL
3 years, 7 months ago (2017-05-09 09:10:18 UTC) #9
robertshield
lgtm
3 years, 7 months ago (2017-05-09 13:29:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867723002/20001
3 years, 7 months ago (2017-05-09 14:15:24 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 14:23:54 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5fa4456aa172ddb1dd6bb4703678...

Powered by Google App Engine
This is Rietveld 408576698