third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py - Issue 2867713007: webkitpy: Make webkit_base() protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py

Issue 2867713007: webkitpy: Make webkit_base() protected. (Closed)

Patch Set: Removed a code comment, avoid a pylint warning Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py

index 8cc1462190b034d13f92cde8cfc02a9e8c720170..45746d9aabaef9a1c2d1f7dda4f096236a6ed36b 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py

@@ -465,9 +465,6 @@ class TestPort(Port):

def perf_tests_dir(self):

return PERF_TEST_DIR

- def webkit_base(self):

- return '/test.checkout'

def skipped_layout_tests(self, _):

return set(['failures/expected/skip_text.html',

'failures/unexpected/skip_pass.html',