Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2867713007: webkitpy: Make webkit_base() protected. (Closed)
Patch Set: Removed a code comment, avoid a pylint warning Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
index 63b391562c3afb6155769d07605c2f6341927505..8b60c5283424c20cca31d65b5baae6653b0f5780 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -870,22 +870,19 @@ class Port(object):
self._filesystem.write_binary_file(baseline_path, data)
# TODO(qyearsley): Update callers to create a finder and call it instead
- # of these next three routines (which should be protected).
- def webkit_base(self):
- return self._webkit_finder.webkit_base()
-
+ # of these next two routines (which should be protected).
def path_from_chromium_base(self, *comps):
return self._webkit_finder.path_from_chromium_base(*comps)
+ def perf_tests_dir(self):
+ return self._webkit_finder.perf_tests_dir()
+
def layout_tests_dir(self):
custom_layout_tests_dir = self.get_option('layout_tests_directory')
if custom_layout_tests_dir:
return custom_layout_tests_dir
return self._webkit_finder.layout_tests_dir()
- def perf_tests_dir(self):
- return self._webkit_finder.perf_tests_dir()
-
def skipped_layout_tests(self, _):
# TODO(qyearsley): Remove this method.
return set()

Powered by Google App Engine
This is Rietveld 408576698