Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2867713005: Use constexpr TaskTraits constructor in feedback_data.cc. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
bsimonnet, gab, rkc1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use constexpr TaskTraits constructor in feedback_data.cc. Use a constexpr constructor that accepts traits in any order instead of the builder pattern to construct TaskTraits in net. BUG=713683 TBR=gab@chromium.org,bsimonnet@chromium.org Review-Url: https://codereview.chromium.org/2867713005 Cr-Commit-Position: refs/heads/master@{#470138} Committed: https://chromium.googlesource.com/chromium/src/+/eee2186f0e38677b7fa0e804da2037b07ab7b6c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M components/feedback/feedback_data.cc View 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
fdoray
PTAL
3 years, 7 months ago (2017-05-08 20:11:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867713005/1
3 years, 7 months ago (2017-05-08 20:12:29 UTC) #3
fdoray
PTAL
3 years, 7 months ago (2017-05-08 20:12:41 UTC) #6
rkc1
Seems like a mechanical change. rs-lgtm
3 years, 7 months ago (2017-05-08 20:13:32 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 21:38:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eee2186f0e38677b7fa0e804da20...

Powered by Google App Engine
This is Rietveld 408576698