Changed PassRefPtr templated copy constructor to move constructor.

Changed PassRefPtr templated copy constructor to move constructor.

Changed argument in PassRefPtr constructor that takes a PassRefPtr with
a different inner type from a const lvalue to an rvalue, making the
constructor a move constructor instead of a copy constructor and
forbidding PassRefPtr copies when the inner type is different.

Added move wraps to call sites to ensure they pass rvalues.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

BUG=640449
Review-Url: https://codereview.chromium.org/2867693003
Cr-Commit-Position: refs/heads/master@{#470219}
Committed: https://chromium.googlesource.com/chromium/src/+/9a44821bd6c02f83896fe03e842f9982703c6b15

[Bugs Nash, 2017-05-08 05:29:35]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 05:29:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-05-08 05:32:54]

bugsnash@chromium.org changed reviewers:
+ haraken@chromium.org, yutak@chromium.org

[Bugs Nash, 2017-05-08 05:32:54]

Please note that there is no equivalent move constructor for RefPtr with
different inner types. This will need to be added before PassRefPtr can be
replaced with RefPtr. I am happy to add it in this patch, however it will not be
used yet if I do. I am also happy to add it later when I start changing
PassRefPtr to RefPtr and it will be used.

[haraken, 2017-05-08 05:51:06]

On 2017/05/08 05:32:54, Bugs Nash wrote:
> Please note that there is no equivalent move constructor for RefPtr with
> different inner types. This will need to be added before PassRefPtr can be
> replaced with RefPtr. I am happy to add it in this patch, however it will not
be
> used yet if I do. I am also happy to add it later when I start changing
> PassRefPtr to RefPtr and it will be used.

LGTM.

[Yuta Kitamura, 2017-05-08 05:55:21]

LGTM, this is exciting!

[commit-bot: I haz the power, 2017-05-08 09:31:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 09:31:04]

Dry run: This issue passed the CQ dry run.

[Bugs Nash, 2017-05-09 04:24:56]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2017-05-09 04:25:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:43:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494303896351850, "parent_rev":
"4000f08774959883da8bef366561798e98cb50eb", "commit_rev":
"9a44821bd6c02f83896fe03e842f9982703c6b15"}

[commit-bot: I haz the power, 2017-05-09 04:43:40]

Description was changed from

==========
Changed PassRefPtr templated copy constructor to move constructor.

Changed argument in PassRefPtr constructor that takes a PassRefPtr with
a different inner type from a const lvalue to an rvalue, making the
constructor a move constructor instead of a copy constructor and
forbidding PassRefPtr copies when the inner type is different.

Added move wraps to call sites to ensure they pass rvalues.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

BUG=640449
==========

to

==========
Changed PassRefPtr templated copy constructor to move constructor.

Changed argument in PassRefPtr constructor that takes a PassRefPtr with
a different inner type from a const lvalue to an rvalue, making the
constructor a move constructor instead of a copy constructor and
forbidding PassRefPtr copies when the inner type is different.

Added move wraps to call sites to ensure they pass rvalues.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

BUG=640449

Review-Url: https://codereview.chromium.org/2867693003
Cr-Commit-Position: refs/heads/master@{#470219}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a44821bd6c02f83896fe03e842f...
==========

[commit-bot: I haz the power, 2017-05-09 04:43:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a44821bd6c02f83896fe03e842f...