Chromium Code Reviews Chromium Code Reviews
Issue 2867683003:
[i18n] dir header i18n-content/values to $i18n (Closed)
| Index: net/base/dir_header.html |
| diff --git a/net/base/dir_header.html b/net/base/dir_header.html |
| index b4cefe5db06017ec050ab55476ba2f0419ec7415..872d993ef2c6f704d026e77bce6b047a816d56b2 100644 |
| --- a/net/base/dir_header.html |
| +++ b/net/base/dir_header.html |
| @@ -1,6 +1,6 @@ |
| <!DOCTYPE html> |
| -<html i18n-values="dir:textdirection;lang:language"> |
| +<html dir="$i18n{textdirection}" lang="$i18n{language}"> |
| <head> |
| <meta charset="utf-8"> |
| @@ -192,22 +192,27 @@ function sortTable(column) { |
| <body> |
| -<div id="listingParsingErrorBox" i18n-values=".innerHTML:listingParsingErrorBoxText"></div> |
| +<div id="listingParsingErrorBox" .innerHTML="$i18n{listingParsingErrorBoxText}"> |
|
tommycli
2017/05/09 18:14:54
nit: is that legit? Shouldn't it just be a i18nRaw
dschuyler
2017/05/09 19:07:16
Thanks!
This text includes a url so it needs i18nR
|
| +</div> |
| -<h1 id="header" i18n-content="header"></h1> |
| +<h1 id="header">$i18n{header}</h1> |
| <div id="parentDirLinkBox" style="display:none"> |
| <a id="parentDirLink" class="icon up"> |
| - <span id="parentDirText" i18n-content="parentDirText"></span> |
| + <span id="parentDirText">$i18n{parentDirText}</span> |
| </a> |
| </div> |
| <table> |
| <thead> |
| <tr class="header" id="theader"> |
| - <th i18n-content="headerName" onclick="javascript:sortTable(0);"></th> |
| - <th class="detailsColumn" i18n-content="headerSize" onclick="javascript:sortTable(1);"></th> |
| - <th class="detailsColumn" i18n-content="headerDateModified" onclick="javascript:sortTable(2);"></th> |
| + <th onclick="javascript:sortTable(0);">$i18n{headerName}</th> |
| + <th class="detailsColumn" onclick="javascript:sortTable(1);"> |
| + $i18n{headerSize} |
| + </th> |
| + <th class="detailsColumn" onclick="javascript:sortTable(2);"> |
| + $i18n{headerDateModified} |
| + </th> |
| </tr> |
| </thead> |
| <tbody id="tbody"> |
