Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: ui/views/window/dialog_delegate.cc

Issue 2867683002: Log the creation of dialog boxes using DialogDelegateView and BubbleDialogDelegateView. (Closed)
Patch Set: Use histogram_suffixes. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/window/dialog_delegate.cc
diff --git a/ui/views/window/dialog_delegate.cc b/ui/views/window/dialog_delegate.cc
index 6af25ee59accfbcb26ef5379fe67751d4fff6cef..8dfd5144cc097e70a47eed768a1e8cbf330860ac 100644
--- a/ui/views/window/dialog_delegate.cc
+++ b/ui/views/window/dialog_delegate.cc
@@ -239,6 +239,7 @@ ui::AXRole DialogDelegate::GetAccessibleWindowRole() const {
DialogDelegateView::DialogDelegateView() {
// A WidgetDelegate should be deleted on DeleteDelegate.
set_owned_by_client();
+ UMA_HISTOGRAM_BOOLEAN("Dialog.DelegateView.Create", true);
msw 2017/05/11 00:54:40 nit: maybe this should be Dialog.DialogDelegateVie
pdyson 2017/05/11 05:54:01 Done. I have another cl to change Dialog.Delegate
}
DialogDelegateView::~DialogDelegateView() {}
« tools/metrics/histograms/histograms.xml ('K') | « ui/views/bubble/bubble_dialog_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698