Log the creation of dialog boxes using DialogDelegateView and BubbleDialogDelegateView.

ui/views/window/dialog_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/window/dialog_delegate.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 15 matching lines @@
 #if defined(OS_WIN)
 #include "ui/base/win/shell.h"
 #endif
 
 namespace views {
 
 ////////////////////////////////////////////////////////////////////////////////
 // DialogDelegate:
 
 DialogDelegate::DialogDelegate() : supports_custom_frame_(true) {
   UMA_HISTOGRAM_BOOLEAN("Dialog.Delegate.Creation", true);

[msw, 2017/05/11 00:54:40]

nit: maybe this should be Dialog.DialogDelegate.Create (or Creation)?

 }
 
 DialogDelegate::~DialogDelegate() {}
 
 // static
 Widget* DialogDelegate::CreateDialogWidget(WidgetDelegate* delegate,
                                            gfx::NativeWindow context,
                                            gfx::NativeView parent) {
   views::Widget* widget = new views::Widget;
   views::Widget::InitParams params =
@@ skipping 185 matching lines @@
 ui::AXRole DialogDelegate::GetAccessibleWindowRole() const {
   return ui::AX_ROLE_DIALOG;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // DialogDelegateView:
 
 DialogDelegateView::DialogDelegateView() {
   // A WidgetDelegate should be deleted on DeleteDelegate.
   set_owned_by_client();
+  UMA_HISTOGRAM_BOOLEAN("Dialog.DelegateView.Create", true);

[msw, 2017/05/11 00:54:40]

nit: maybe this should be Dialog.DialogDelegateView.Create?

[pdyson, 2017/05/11 05:54:01]

Done.

I have another cl to change Dialog.Delegate.Creation to be of the form
Dialog.*.Create. So I'll make that Dialog.DialogDelegate.Create so this is all
consistent.

 }
 
 DialogDelegateView::~DialogDelegateView() {}
 
 void DialogDelegateView::DeleteDelegate() {
   delete this;
 }
 
 Widget* DialogDelegateView::GetWidget() {
   return View::GetWidget();
@@ skipping 12 matching lines @@
   node_data->role = ui::AX_ROLE_DIALOG;
 }
 
 void DialogDelegateView::ViewHierarchyChanged(
     const ViewHierarchyChangedDetails& details) {
   if (details.is_add && details.child == this && GetWidget())
     NotifyAccessibilityEvent(ui::AX_EVENT_ALERT, true);
 }
 
 }  // namespace views