Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2867673005: content: add missing entries to common's BUILD.gn file (Closed)

Created:
3 years, 7 months ago by tfarina
Modified:
3 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, darin-cc_chromium.org, wychen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

content: add missing entries to common's BUILD.gn file These were header files that should have been listed in the sources list, but weren't. https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0 https://groups.google.com/a/chromium.org/d/topic/chromium-dev/1kK45mVemBc/discussion BUG=661774 R=avi@chromium.org Review-Url: https://codereview.chromium.org/2867673005 Cr-Commit-Position: refs/heads/master@{#470110} Committed: https://chromium.googlesource.com/chromium/src/+/6c067d4597d22586b8d51ef59ed8916378101239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/common/BUILD.gn View 7 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tfarina
3 years, 7 months ago (2017-05-08 17:28:52 UTC) #2
Avi (use Gerrit)
lgtm
3 years, 7 months ago (2017-05-08 18:12:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867673005/1
3 years, 7 months ago (2017-05-08 20:18:38 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 20:30:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c067d4597d22586b8d51ef59ed8...

Powered by Google App Engine
This is Rietveld 408576698