Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2867663006: Update expected shell version to 4. (Closed)

Created:
3 years, 7 months ago by Yaron
Modified:
3 years, 7 months ago
Reviewers:
pkotwicz, hartmanng
CC:
chromium-reviews, zpeng+watch_chromium.org, pkotwicz, Xi Han
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update expected shell version to 4. Server is now vending this. BUG=b/38157901 Review-Url: https://codereview.chromium.org/2867663006 Cr-Commit-Position: refs/heads/master@{#470548} Committed: https://chromium.googlesource.com/chromium/src/+/15fa40c5ef33b76a60a40661452716a822c357e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/webapk/shell_apk/shell_apk_version.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (13 generated)
Yaron
3 years, 7 months ago (2017-05-09 14:42:07 UTC) #2
pkotwicz
It is probably wise to wait till https://codereview.chromium.org/2849873002/ lands (Otherwise we will need to update ...
3 years, 7 months ago (2017-05-09 15:33:55 UTC) #4
Yaron
honestly i'm not worried about churn on canary/dev/beta channels
3 years, 7 months ago (2017-05-09 16:09:03 UTC) #5
hartmanng
lgtm
3 years, 7 months ago (2017-05-09 16:40:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867663006/1
3 years, 7 months ago (2017-05-09 17:56:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/335374)
3 years, 7 months ago (2017-05-09 18:35:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867663006/1
3 years, 7 months ago (2017-05-09 19:05:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/264150)
3 years, 7 months ago (2017-05-09 20:28:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867663006/1
3 years, 7 months ago (2017-05-09 22:04:02 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 00:08:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867663006/1
3 years, 7 months ago (2017-05-10 02:00:28 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 04:04:04 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867663006/1
3 years, 7 months ago (2017-05-10 10:53:57 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 13:11:04 UTC) #27
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/15fa40c5ef33b76a60a406614527...

Powered by Google App Engine
This is Rietveld 408576698