Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2867663004: WebUI: Add ESLint to node_modules dependencies. (Closed)

Created:
3 years, 7 months ago by dpapad
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Dan Beam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Add ESLint to node_modules dependencies. BUG=720034 Review-Url: https://codereview.chromium.org/2867663004 Cr-Commit-Position: refs/heads/master@{#473737} Committed: https://chromium.googlesource.com/chromium/src/+/90880bc17b25c2760518e056cdcd820e7d5f287e

Patch Set 1 : Add PathToEsLint #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/node/node_modules.py View 1 chunk +4 lines, -0 lines 1 comment Download
M third_party/node/node_modules.tar.gz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/node/package.json View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (12 generated)
dpapad
I am planning to ask for licensing and security LGTM's before landing this CL (I ...
3 years, 7 months ago (2017-05-20 00:00:13 UTC) #8
dglazkov
lgtm
3 years, 7 months ago (2017-05-20 01:44:35 UTC) #9
dpapad
On 2017/05/20 at 01:44:35, dglazkov wrote: > lgtm Adding palmer@ for security LGTM.
3 years, 7 months ago (2017-05-22 16:53:22 UTC) #11
palmer
lgtm
3 years, 7 months ago (2017-05-22 17:05:54 UTC) #12
dpapad
On 2017/05/22 at 17:05:54, palmer wrote: > lgtm Received licensing LGTM from open-source-third-party-reviews@google.com. Landing...
3 years, 7 months ago (2017-05-22 22:16:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867663004/20001
3 years, 7 months ago (2017-05-22 22:16:39 UTC) #15
Dan Beam
lgtm https://codereview.chromium.org/2867663004/diff/20001/third_party/node/node_modules.py File third_party/node/node_modules.py (right): https://codereview.chromium.org/2867663004/diff/20001/third_party/node/node_modules.py#newcode32 third_party/node/node_modules.py:32: def PathToEsLint(): arguable nit: alphabetize these?
3 years, 7 months ago (2017-05-22 23:08:30 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 23:14:32 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/90880bc17b25c2760518e056cdcd...

Powered by Google App Engine
This is Rietveld 408576698