Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2867633002: Fetch the surface from GpuSurfaceTracker for mojo AndroidOverlay. (Closed)

Created:
3 years, 7 months ago by liberato (no reviews please)
Modified:
3 years, 7 months ago
Reviewers:
tguilbert
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fetch the surface from GpuSurfaceTracker for mojo AndroidOverlay. This CL makes the mojo AndroidOverlay client fetch the Android surface from GpuSurfaceTracker when notified by the service that the overlay is ready. This also updates the tests to register a surface, and verify that the same one is returned by the mojo client. BUG=719591 Review-Url: https://codereview.chromium.org/2867633002 Cr-Commit-Position: refs/heads/master@{#470106} Committed: https://chromium.googlesource.com/chromium/src/+/e7c8abfdf3ce705d4070c4d5c457381dbee89a84

Patch Set 1 #

Patch Set 2 : added gn dep #

Patch Set 3 : added surface to GpuSurfaceTracker #

Patch Set 4 : added gpu/ipc/common to unit tests deps #

Patch Set 5 : added gl to deps too #

Patch Set 6 : started checking surface obj #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -5 lines) Patch
M media/mojo/BUILD.gn View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M media/mojo/clients/BUILD.gn View 1 1 chunk +4 lines, -1 line 0 comments Download
M media/mojo/clients/mojo_android_overlay.cc View 2 chunks +13 lines, -1 line 0 comments Download
M media/mojo/clients/mojo_android_overlay_unittest.cc View 1 2 3 4 5 4 chunks +38 lines, -3 lines 0 comments Download

Messages

Total messages: 31 (27 generated)
liberato (no reviews please)
without this, the mojo client gets the surface id from the service, then does nothing. ...
3 years, 7 months ago (2017-05-08 17:32:25 UTC) #23
tguilbert
LGTM
3 years, 7 months ago (2017-05-08 19:52:15 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867633002/100001
3 years, 7 months ago (2017-05-08 20:16:00 UTC) #28
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 20:27:26 UTC) #31
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/e7c8abfdf3ce705d4070c4d5c457...

Powered by Google App Engine
This is Rietveld 408576698