Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Issue 2867593002: Enables omnibox_perftest that were failing. (Closed)

Created:
3 years, 7 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enables omnibox_perftest that were failing. Added more TestWebState scaffolding for the tests to run. BUG=717309 Review-Url: https://codereview.chromium.org/2867593002 Cr-Commit-Position: refs/heads/master@{#470306} Committed: https://chromium.googlesource.com/chromium/src/+/37902cbceb02b72f5e904fc2ace9167a7acb3823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M ios/chrome/browser/ui/omnibox_perftest.mm View 5 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pkl (ping after 24h if needed)
eugenebut: who suggested the fix. rohitrao: for OWNERS.
3 years, 7 months ago (2017-05-05 23:50:31 UTC) #2
Eugene But (OOO till 7-30)
Thank you for fixing this! lgtm
3 years, 7 months ago (2017-05-08 15:57:37 UTC) #3
rohitrao (ping after 24h)
lgtm
3 years, 7 months ago (2017-05-09 13:10:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867593002/1
3 years, 7 months ago (2017-05-09 13:15:04 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 13:26:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37902cbceb02b72f5e904fc2ace9...

Powered by Google App Engine
This is Rietveld 408576698