Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: ios/chrome/browser/ui/settings/passwords_settings_egtest.mm

Issue 2867553002: Make settings_egtest.mm work in landscape on small phones. (Closed)
Patch Set: revert extra history_ui_egtest change Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
diff --git a/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm b/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
index b60fbb03a279548e6b86688e91e22d9d58433a35..d36f421e0a9546cd0459dee2dff55aebc214f43b 100644
--- a/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
+++ b/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
@@ -46,6 +46,7 @@ using autofill::PasswordForm;
using chrome_test_util::ButtonWithAccessibilityLabel;
using chrome_test_util::ButtonWithAccessibilityLabelId;
using chrome_test_util::NavigationBarDoneButton;
+using chrome_test_util::SettingsMenuButton;
namespace {
@@ -54,11 +55,6 @@ namespace {
// it too high could result in scrolling way past the searched element.
constexpr int kScrollAmount = 150;
-// Matcher for the Settings button in the tools menu.
-id<GREYMatcher> SettingsButton() {
- return grey_accessibilityID(kToolsMenuSettingsId);
-}
-
// Matcher for the Save Passwords cell on the main Settings screen.
id<GREYMatcher> PasswordsButton() {
return ButtonWithAccessibilityLabelId(IDS_IOS_SAVE_PASSWORDS);
@@ -287,7 +283,7 @@ id<GREYMatcher> CopyPasswordButton() {
- (void)openPasswordSettings {
// Open settings and verify data in the view controller.
[ChromeEarlGreyUI openToolsMenu];
- [[EarlGrey selectElementWithMatcher:SettingsButton()]
+ [[EarlGrey selectElementWithMatcher:SettingsMenuButton()]
performAction:grey_tap()];
[[EarlGrey selectElementWithMatcher:PasswordsButton()]
performAction:grey_tap()];
« no previous file with comments | « ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm ('k') | ios/chrome/browser/ui/settings/settings_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698