Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm

Issue 2867553002: Make settings_egtest.mm work in landscape on small phones. (Closed)
Patch Set: revert extra history_ui_egtest change Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/settings/passwords_settings_egtest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
diff --git a/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm b/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
index f8c0c588e14e5b4c65bdf88cdbffe4691952d449..8a762f9c059b84964adff468ca9a5a614e71ecd2 100644
--- a/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
+++ b/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
@@ -41,6 +41,7 @@
#endif
using chrome_test_util::OpenLinkInNewTabButton;
+using chrome_test_util::SettingsMenuButton;
using tab_usage_recorder_test_util::OpenNewIncognitoTabUsingUIAndEvictMainTabs;
using tab_usage_recorder_test_util::SwitchToNormalMode;
@@ -148,10 +149,7 @@ void OpenSettingsMenuUnsynced() {
grey_accessibilityID(kToolbarToolsMenuButtonIdentifier);
WaitAndTap(tool_menu_matcher, @"Tool menu");
- id<GREYMatcher> settings_button_matcher =
- grey_accessibilityID(kToolsMenuSettingsId);
-
- WaitAndTap(settings_button_matcher, @"Settings menu");
+ WaitAndTap(SettingsMenuButton(), @"Settings menu");
Wait(grey_accessibilityID(kSettingsCollectionViewId), @"Setting view");
}
« no previous file with comments | « no previous file | ios/chrome/browser/ui/settings/passwords_settings_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698