Make settings_egtest.mm work in landscape on small phones.

ios/chrome/test/earl_grey/chrome_earl_grey_ui.h

Index: ios/chrome/test/earl_grey/chrome_earl_grey_ui.h
diff --git a/ios/chrome/test/earl_grey/chrome_earl_grey_ui.h b/ios/chrome/test/earl_grey/chrome_earl_grey_ui.h
index ea7dd86a46c3ba03897d187ac3537215f3c5f347..986983f0187515d6f206087b360b215dabb78218 100644
--- a/ios/chrome/test/earl_grey/chrome_earl_grey_ui.h
+++ b/ios/chrome/test/earl_grey/chrome_earl_grey_ui.h
@@ -5,6 +5,7 @@
 #ifndef IOS_CHROME_TEST_EARL_GREY_CHROME_EARL_GREY_UI_H_
 #define IOS_CHROME_TEST_EARL_GREY_CHROME_EARL_GREY_UI_H_
 
+#import <EarlGrey/EarlGrey.h>
 #import <Foundation/Foundation.h>
 
 // Test methods that perform actions on Chrome. These methods only affect Chrome
@@ -21,6 +22,22 @@
 // calling this method.
 + (void)openSettingsMenu;
 
+// Scrolls to find the button in the Settings menu with the corresponding

[Eugene But (OOO till 7-30), 2017/05/09 00:15:03]

Is this API used anywhere except settings tests? If no, would it be better to
move this code to test file?

[baxley, 2017/05/09 18:39:19]

Yes, it is used in some other tests. However, the other two aren't...

My biggest concern of moving them is that scrolling menus can have subtle bugs
if done incorrectly, and there are about 5 different ways to do it, where only
one works. We have had multiple test bugs with this. However, I also don't like
cluttering this file with APIs only used in one test class. :)

What do you think if I expose ScrollDown() as ScrollMenuDown() in
chrome_actions, then call-sites could use that as their search action? Then
tapSettingsMenuButton would live here, and I'd move the other two tap APIs into
settings_egtest.mm? Even if we have the helpers here, it won't prevent tests
from doing it themselves. Having a custom scroll action might help?

I wanted to check before moving anything, or to see if you had other ideas.

[baxley, 2017/05/09 20:16:39]

After offline discussion with eugenebut@ it was determined that it can stay as
is. It's not clear how big this file will grow, and if/where would be the good
places to start splitting things up.

+// |buttonMatcher|, and then taps it. If |buttonMatcher| is not found, or
+// the Settings menu is not open when this is called there will be a GREYAssert.
++ (void)tapButtonInSettingsMenu:(id<GREYMatcher>)buttonMatcher;

[Eugene But (OOO till 7-30), 2017/05/09 00:15:03]

Per Cocoa Guidelines for Coding, make world(s) before the argument describe the
argument. e.g. tapSettingsMenuButton:

Same comment for other names

[baxley, 2017/05/09 18:39:19]

Done.

+
+// Scrolls to find the button in the Privacy menu with the corresponding
+// |buttonMatcher|, and then taps it. If |buttonMatcher| is not found, or
+// the Privacy menu is not open when this is called there will be a GREYAssert.
++ (void)tapButtonInPrivacyMenu:(id<GREYMatcher>)buttonMatcher;
+
+// Scrolls to find the button in the Clear Browsing Data menu with the
+// corresponding |buttonMatcher|, and then taps it. If |buttonMatcher| is
+// not found, or the Clear Browsing Data menu is not open when this is called
+// there will be a GREYAssert.
++ (void)tapButtonInClearBrowsingDataMenu:(id<GREYMatcher>)buttonMatcher;
+
 // Open a new tab via the tools menu.
 + (void)openNewTab;