Make settings_egtest.mm work in landscape on small phones.

ios/chrome/test/earl_grey/chrome_earl_grey_ui.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_TEST_EARL_GREY_CHROME_EARL_GREY_UI_H_
 #define IOS_CHROME_TEST_EARL_GREY_CHROME_EARL_GREY_UI_H_
 
+#import <EarlGrey/EarlGrey.h>
 #import <Foundation/Foundation.h>
 
 // Test methods that perform actions on Chrome. These methods only affect Chrome
 // using the UI with Earl Grey.
 @interface ChromeEarlGreyUI : NSObject
 
 // Makes the toolbar visible by swiping downward, if necessary. Then taps on
 // the Tools menu button. At least one tab needs to be open and visible when
 // calling this method.
 + (void)openToolsMenu;
 
 // Opens the settings menu by opening the tools menu, and then tapping the
 // Settings button. There will be a GREYAssert if the tools menu is open when
 // calling this method.
 + (void)openSettingsMenu;
 
+// Scrolls to find the button in the Settings menu with the corresponding

[Eugene But (OOO till 7-30), 2017/05/09 00:15:03]

Is this API used anywhere except settings tests? If no, would it be better to
move this code to test file?

[baxley, 2017/05/09 18:39:19]

Yes, it is used in some other tests. However, the other two aren't...

My biggest concern of moving them is that scrolling menus can have subtle bugs
if done incorrectly, and there are about 5 different ways to do it, where only
one works. We have had multiple test bugs with this. However, I also don't like
cluttering this file with APIs only used in one test class. :)

What do you think if I expose ScrollDown() as ScrollMenuDown() in
chrome_actions, then call-sites could use that as their search action? Then
tapSettingsMenuButton would live here, and I'd move the other two tap APIs into
settings_egtest.mm? Even if we have the helpers here, it won't prevent tests
from doing it themselves. Having a custom scroll action might help?

I wanted to check before moving anything, or to see if you had other ideas.

[baxley, 2017/05/09 20:16:39]

After offline discussion with eugenebut@ it was determined that it can stay as
is. It's not clear how big this file will grow, and if/where would be the good
places to start splitting things up.

+// |buttonMatcher|, and then taps it. If |buttonMatcher| is not found, or
+// the Settings menu is not open when this is called there will be a GREYAssert.
++ (void)tapButtonInSettingsMenu:(id<GREYMatcher>)buttonMatcher;

[Eugene But (OOO till 7-30), 2017/05/09 00:15:03]

Per Cocoa Guidelines for Coding, make world(s) before the argument describe the
argument. e.g. tapSettingsMenuButton:

Same comment for other names

[baxley, 2017/05/09 18:39:19]

Done.

+
+// Scrolls to find the button in the Privacy menu with the corresponding
+// |buttonMatcher|, and then taps it. If |buttonMatcher| is not found, or
+// the Privacy menu is not open when this is called there will be a GREYAssert.
++ (void)tapButtonInPrivacyMenu:(id<GREYMatcher>)buttonMatcher;
+
+// Scrolls to find the button in the Clear Browsing Data menu with the
+// corresponding |buttonMatcher|, and then taps it. If |buttonMatcher| is
+// not found, or the Clear Browsing Data menu is not open when this is called
+// there will be a GREYAssert.
++ (void)tapButtonInClearBrowsingDataMenu:(id<GREYMatcher>)buttonMatcher;
+
 // Open a new tab via the tools menu.
 + (void)openNewTab;
 
 // Open a new incognito tab via the tools menu.
 + (void)openNewIncognitoTab;
 
 // Reloads the page via the reload button, and does not wait for the page to
 // finish loading.
 + (void)reload;
 
 // Opens the share menu via the share button.
 // This method requires that there is at least one tab open.
 + (void)openShareMenu;
 
 // Waits for toolbar to become visible if |isVisible| is YES, otherwise waits
 // for it to disappear. If the condition is not met within a timeout, a
 // GREYAssert is induced.
 + (void)waitForToolbarVisible:(BOOL)isVisible;
 
 @end
 
 #endif  // IOS_CHROME_TEST_EARL_GREY_CHROME_EARL_GREY_UI_H_