Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2867543002: content: add header files of public that were not listed in the BUILD.gn file (Closed)

Created:
3 years, 7 months ago by tfarina
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, wychen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix check failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/BUILD.gn View 4 chunks +4 lines, -0 lines 0 comments Download
M content/public/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
tfarina
3 years, 7 months ago (2017-05-05 19:03:12 UTC) #2
Avi (use Gerrit)
lgtm nice!
3 years, 7 months ago (2017-05-05 19:06:30 UTC) #4
tfarina
Avi, could you take a look at the addition in content/test at patch set 2?
3 years, 7 months ago (2017-05-05 19:18:32 UTC) #7
wychen
Thanks for fixing this. https://codereview.chromium.org/2867543002/diff2/1:20001/content/browser/BUILD.gn was a bit confusing since it's from rebasing.
3 years, 7 months ago (2017-05-05 19:21:19 UTC) #11
Avi (use Gerrit)
lgtm
3 years, 7 months ago (2017-05-05 19:38:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867543002/20001
3 years, 7 months ago (2017-05-05 21:10:42 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 23:06:41 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/175c5da545b7eb584f4916cc19f8...

Powered by Google App Engine
This is Rietveld 408576698