Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 286753002: Revert 270290 "Reduce creation of ViewsDelegate" (Closed)

Created:
6 years, 7 months ago by raymes
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 270290 "Reduce creation of ViewsDelegate" Speculatively reverting as it may have caused the tree to break: http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/20345/steps/compile/logs/stdio > Reduce creation of ViewsDelegate > > By consolidating override of OnBeforeWidgetInit that finds shell many > of the places that were setting a viewsdelegate no longer need to. > > Also, made AshTestHelper install a ViewsDelegate so that tests don't have. > > Because of removed an include of views_delegate from ash_test_helper I had to update some includes. > > BUG=none > TEST=none > R=ben@chromium.org > > Review URL: https://codereview.chromium.org/280863002 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -103 lines) Patch
M trunk/src/ash/ash.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/ash/drag_drop/drag_drop_controller_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/ash/first_run/first_run_helper_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/screensaver/screensaver_view_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/ash/test/ash_test_base.h View 2 chunks +9 lines, -4 lines 0 comments Download
M trunk/src/ash/test/ash_test_base.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M trunk/src/ash/test/ash_test_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/test/ash_test_helper.cc View 4 chunks +3 lines, -3 lines 0 comments Download
D trunk/src/ash/test/ash_test_views_delegate.h View 1 chunk +0 lines, -37 lines 0 comments Download
D trunk/src/ash/test/ash_test_views_delegate.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M trunk/src/ash/touch/touch_observer_hud_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/signin/signin_error_notifier_ash_unittest.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/sync/sync_error_notifier_ash_unittest.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
A + trunk/src/chrome/browser/ui/ash/test_views_delegate_with_parent.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/ash/test_views_delegate_with_parent.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/test/base/browser_with_test_window_test.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/test/base/browser_with_test_window_test.cc View 5 chunks +5 lines, -9 lines 0 comments Download
M trunk/src/ui/views/test/test_views_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
raymes
6 years, 7 months ago (2014-05-14 02:43:39 UTC) #1
raymes
6 years, 7 months ago (2014-05-14 02:44:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r270305 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698