Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 280863002: Reduce creation of ViewsDelegate (Closed)

Created:
6 years, 7 months ago by sky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, sadrul, tfarina, haitaol+watch_chromium.org, dcheng, kalyank, ben+ash_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Reduce creation of ViewsDelegate By consolidating override of OnBeforeWidgetInit that finds shell many of the places that were setting a viewsdelegate no longer need to. Also, made AshTestHelper install a ViewsDelegate so that tests don't have. Because of removed an include of views_delegate from ash_test_helper I had to update some includes. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270290 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270399

Patch Set 1 #

Patch Set 2 : merge 2 trunk #

Patch Set 3 : check for instance #

Patch Set 4 : revert on trunk #

Patch Set 5 : add widget includes for undef CreateWindow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -100 lines) Patch
M ash/ash.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M ash/first_run/first_run_helper_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/screensaver/screensaver_view_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.h View 2 chunks +4 lines, -9 lines 0 comments Download
M ash/test/ash_test_base.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M ash/test/ash_test_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/test/ash_test_helper.cc View 4 chunks +3 lines, -3 lines 0 comments Download
A ash/test/ash_test_views_delegate.h View 1 chunk +37 lines, -0 lines 0 comments Download
A ash/test/ash_test_views_delegate.cc View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
M ash/touch/touch_observer_hud_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/gestures/overview_gesture_handler_unittest.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/mru_window_tracker_unittest.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash_unittest.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash_unittest.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D chrome/browser/ui/ash/test_views_delegate_with_parent.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/ui/ash/test_views_delegate_with_parent.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M ui/views/test/test_views_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
sky
6 years, 7 months ago (2014-05-13 18:24:29 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 7 months ago (2014-05-13 19:41:03 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-13 19:41:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/280863002/1
6 years, 7 months ago (2014-05-13 19:43:31 UTC) #4
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-13 21:55:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/280863002/40001
6 years, 7 months ago (2014-05-13 22:04:53 UTC) #6
commit-bot: I haz the power
Change committed as 270290
6 years, 7 months ago (2014-05-14 01:56:16 UTC) #7
sky
This was reverted as it broke windows compile. Because I removed an include a couple ...
6 years, 7 months ago (2014-05-14 05:31:19 UTC) #8
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-14 05:31:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/280863002/80001
6 years, 7 months ago (2014-05-14 05:32:25 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 07:12:58 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 07:16:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/74274)
6 years, 7 months ago (2014-05-14 07:16:32 UTC) #13
sky
6 years, 7 months ago (2014-05-14 14:08:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 manually as r270399 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698