Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2867523002: Update Skia GL bindings to include query and MRT functions (Closed)

Created:
3 years, 7 months ago by bsalomon
Modified:
3 years, 7 months ago
Reviewers:
zmo, Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Skia GL bindings to include query and MRT functions CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2867523002 Cr-Commit-Position: refs/heads/master@{#470100} Committed: https://chromium.googlesource.com/chromium/src/+/5a367b9cf506209e6041299beac572a8348df154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc View 6 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
bsalomon
3 years, 7 months ago (2017-05-08 18:55:52 UTC) #11
Zhenyao Mo
On 2017/05/08 18:55:52, bsalomon wrote: lgtm
3 years, 7 months ago (2017-05-08 19:23:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867523002/1
3 years, 7 months ago (2017-05-08 20:03:20 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 20:13:51 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a367b9cf506209e6041299beac5...

Powered by Google App Engine
This is Rietveld 408576698