|
|
Created:
3 years, 7 months ago by chadversary Modified:
3 years, 7 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, extensions-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptiongpu/EGL_CHROMIUM_sync_control: Fix extension name
Rename EGL_CHROMIUM_get_sync_values to EGL_CHROMIUM_sync_control.
EGL_CHROMIUM_sync_control is the de facto extension name because all
users (Chromium and ANGLE, to my knowledge) query that extension string.
And it's also the name exposed Mesa's implementation of the
extension.
BUG=None
Review-Url: https://codereview.chromium.org/2867513002
Cr-Commit-Position: refs/heads/master@{#469868}
Committed: https://chromium.googlesource.com/chromium/src/+/5fbc36a64a6337938eb70e3fc4d0296f3a30cc97
Patch Set 1 #
Messages
Total messages: 27 (15 generated)
Description was changed from ========== gpu/EGL_CHROMIUM_sync_control: Fix extension name Rename EGL_CHROMIUM_get_sync_values to EGL_CHROMIUM_sync_control. EGL_CHROMIUM_sync_control is the de facto extension name because all users (Chromium and ANGLE, to my knowledge) query that extension string. And it's also the name exposed Mesa's implementation of the extension. BUG=None ========== to ========== gpu/EGL_CHROMIUM_sync_control: Fix extension name Rename EGL_CHROMIUM_get_sync_values to EGL_CHROMIUM_sync_control. EGL_CHROMIUM_sync_control is the de facto extension name because all users (Chromium and ANGLE, to my knowledge) query that extension string. And it's also the name exposed Mesa's implementation of the extension. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== gpu/EGL_CHROMIUM_sync_control: Fix extension name Rename EGL_CHROMIUM_get_sync_values to EGL_CHROMIUM_sync_control. EGL_CHROMIUM_sync_control is the de facto extension name because all users (Chromium and ANGLE, to my knowledge) query that extension string. And it's also the name exposed Mesa's implementation of the extension. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu/EGL_CHROMIUM_sync_control: Fix extension name Rename EGL_CHROMIUM_get_sync_values to EGL_CHROMIUM_sync_control. EGL_CHROMIUM_sync_control is the de facto extension name because all users (Chromium and ANGLE, to my knowledge) query that extension string. And it's also the name exposed Mesa's implementation of the extension. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
chadversary@google.com changed reviewers: + marcheu@chromium.org, stanisc@chromium.org
Description was changed from ========== gpu/EGL_CHROMIUM_sync_control: Fix extension name Rename EGL_CHROMIUM_get_sync_values to EGL_CHROMIUM_sync_control. EGL_CHROMIUM_sync_control is the de facto extension name because all users (Chromium and ANGLE, to my knowledge) query that extension string. And it's also the name exposed Mesa's implementation of the extension. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu/EGL_CHROMIUM_sync_control: Fix extension name Rename EGL_CHROMIUM_get_sync_values to EGL_CHROMIUM_sync_control. EGL_CHROMIUM_sync_control is the de facto extension name because all users (Chromium and ANGLE, to my knowledge) query that extension string. And it's also the name exposed Mesa's implementation of the extension. BUG=None CQ_INCLUDE_TRYBOTS= ==========
lgtm
The CQ bit was checked by chadversary@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Your CL can not be processed by CQ because of: * Failed to parse additional trybots: missing master (or bucket) and trybuilders in ``. Correct syntax is "trymaster:bot1,bot2;trybucket:bot3,bot4".
lgtm By the way, there is discussion on dropping this extension from mesa. You should let Chad know if you need it in the long run. Chrome OS stopped requiring it when we switched to freon.
The CQ bit was checked by chadversary@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Your CL can not be processed by CQ because of: * Failed to parse additional trybots: missing master (or bucket) and trybuilders in ``. Correct syntax is "trymaster:bot1,bot2;trybucket:bot3,bot4".
Description was changed from ========== gpu/EGL_CHROMIUM_sync_control: Fix extension name Rename EGL_CHROMIUM_get_sync_values to EGL_CHROMIUM_sync_control. EGL_CHROMIUM_sync_control is the de facto extension name because all users (Chromium and ANGLE, to my knowledge) query that extension string. And it's also the name exposed Mesa's implementation of the extension. BUG=None CQ_INCLUDE_TRYBOTS= ========== to ========== gpu/EGL_CHROMIUM_sync_control: Fix extension name Rename EGL_CHROMIUM_get_sync_values to EGL_CHROMIUM_sync_control. EGL_CHROMIUM_sync_control is the de facto extension name because all users (Chromium and ANGLE, to my knowledge) query that extension string. And it's also the name exposed Mesa's implementation of the extension. BUG=None ==========
The CQ bit was checked by chadversary@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2017/05/05 19:28:14, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) The presubmit bot failed because no one yet from OWNERS has given it LGTM.
chadversary@chromium.org changed reviewers: + piman@chromium.org, zmo@chromium.org
On 2017/05/05 19:32:45, chadversary wrote: > On 2017/05/05 19:28:14, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) > > The presubmit bot failed because no one yet from OWNERS has given it LGTM. lgtm
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1494078896913180, "parent_rev": "df0ca6a4ba79e02b3dac21e82c8f2370eacb7f42", "commit_rev": "5fbc36a64a6337938eb70e3fc4d0296f3a30cc97"}
Message was sent while issue was closed.
Description was changed from ========== gpu/EGL_CHROMIUM_sync_control: Fix extension name Rename EGL_CHROMIUM_get_sync_values to EGL_CHROMIUM_sync_control. EGL_CHROMIUM_sync_control is the de facto extension name because all users (Chromium and ANGLE, to my knowledge) query that extension string. And it's also the name exposed Mesa's implementation of the extension. BUG=None ========== to ========== gpu/EGL_CHROMIUM_sync_control: Fix extension name Rename EGL_CHROMIUM_get_sync_values to EGL_CHROMIUM_sync_control. EGL_CHROMIUM_sync_control is the de facto extension name because all users (Chromium and ANGLE, to my knowledge) query that extension string. And it's also the name exposed Mesa's implementation of the extension. BUG=None Review-Url: https://codereview.chromium.org/2867513002 Cr-Commit-Position: refs/heads/master@{#469868} Committed: https://chromium.googlesource.com/chromium/src/+/5fbc36a64a6337938eb70e3fc4d0... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5fbc36a64a6337938eb70e3fc4d0... |