Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2867513002: gpu/EGL_CHROMIUM_sync_control: Fix extension name (Closed)

Created:
3 years, 7 months ago by chadversary
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu/EGL_CHROMIUM_sync_control: Fix extension name Rename EGL_CHROMIUM_get_sync_values to EGL_CHROMIUM_sync_control. EGL_CHROMIUM_sync_control is the de facto extension name because all users (Chromium and ANGLE, to my knowledge) query that extension string. And it's also the name exposed Mesa's implementation of the extension. BUG=None Review-Url: https://codereview.chromium.org/2867513002 Cr-Commit-Position: refs/heads/master@{#469868} Committed: https://chromium.googlesource.com/chromium/src/+/5fbc36a64a6337938eb70e3fc4d0296f3a30cc97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -134 lines) Patch
D gpu/GLES2/extensions/CHROMIUM/EGL_CHROMIUM_get_sync_values.txt View 1 chunk +0 lines, -131 lines 0 comments Download
A + gpu/GLES2/extensions/CHROMIUM/EGL_CHROMIUM_sync_control.txt View 3 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 27 (15 generated)
stanisc
lgtm
3 years, 7 months ago (2017-05-05 18:31:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867513002/1
3 years, 7 months ago (2017-05-05 18:52:37 UTC) #7
commit-bot: I haz the power
Your CL can not be processed by CQ because of: * Failed to parse additional ...
3 years, 7 months ago (2017-05-05 18:52:38 UTC) #9
marcheu
lgtm By the way, there is discussion on dropping this extension from mesa. You should ...
3 years, 7 months ago (2017-05-05 18:52:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867513002/1
3 years, 7 months ago (2017-05-05 18:57:52 UTC) #12
commit-bot: I haz the power
Your CL can not be processed by CQ because of: * Failed to parse additional ...
3 years, 7 months ago (2017-05-05 18:57:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867513002/1
3 years, 7 months ago (2017-05-05 19:17:56 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/428704)
3 years, 7 months ago (2017-05-05 19:28:14 UTC) #19
chadversary
On 2017/05/05 19:28:14, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 7 months ago (2017-05-05 19:32:45 UTC) #20
Zhenyao Mo
On 2017/05/05 19:32:45, chadversary wrote: > On 2017/05/05 19:28:14, commit-bot: I haz the power wrote: ...
3 years, 7 months ago (2017-05-06 13:54:51 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867513002/1
3 years, 7 months ago (2017-05-06 13:55:17 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-06 19:09:19 UTC) #27
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5fbc36a64a6337938eb70e3fc4d0...

Powered by Google App Engine
This is Rietveld 408576698