Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2867483002: Add V8.ArrayBufferLargeAllocations, deprecate V8.ArrayBufferBigAllocations. (Closed)

Created:
3 years, 7 months ago by kschimpf
Modified:
3 years, 7 months ago
Reviewers:
bbudge, Ilya Sherman, bradn
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add V8.ArrayBufferLargeAllocations, deprecate V8.ArrayBufferBigAllocations. CL https://codereview.chromium.org/2856663002 modifies V8 to only track array buffer allocations only if the size is at least one megabyte. This is being done because the UMA entry in V8.ArrayBufferBigAllocations for sizes < 1Mb is so large (at least 99.93%) that the rest of the distribution was not visually visible. To do this, the old table V8.ArrayBufferBigAllocations is marked obsolete, and the new table V8.ArrayBufferLargeAllocations has been added. BUG=chrome:704922 Review-Url: https://codereview.chromium.org/2867483002 Cr-Commit-Position: refs/heads/master@{#469810} Committed: https://chromium.googlesource.com/chromium/src/+/6031a48ccf1fa0ce3b62e3983e01a9b14d1260fe

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
kschimpf
3 years, 7 months ago (2017-05-05 17:06:34 UTC) #3
bbudge
lgtm w/nit https://codereview.chromium.org/2867483002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2867483002/diff/1/tools/metrics/histograms/histograms.xml#newcode77370 tools/metrics/histograms/histograms.xml:77370: + Number of bytes requested in an ...
3 years, 7 months ago (2017-05-05 19:25:52 UTC) #4
Ilya Sherman
LGTM
3 years, 7 months ago (2017-05-05 19:58:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867483002/1
3 years, 7 months ago (2017-05-05 20:01:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867483002/20001
3 years, 7 months ago (2017-05-05 20:06:36 UTC) #11
kschimpf
https://codereview.chromium.org/2867483002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2867483002/diff/1/tools/metrics/histograms/histograms.xml#newcode77370 tools/metrics/histograms/histograms.xml:77370: + Number of bytes requested in an array buffer ...
3 years, 7 months ago (2017-05-05 20:47:09 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 23:47:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6031a48ccf1fa0ce3b62e3983e01...

Powered by Google App Engine
This is Rietveld 408576698