Remove ScopedVector from media/audio/

Remove ScopedVector from media/audio/

base::ScopedVector is deprecated. This CL replaces ScopedVector
with std::vector<std::unique_ptr> in media/audio/.

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2867443002
Cr-Commit-Position: refs/heads/master@{#469627}
Committed: https://chromium.googlesource.com/chromium/src/+/c0671c025e52b6072a6391c8e1cb8ffc4f13a24b

[Chandan, 2017-05-05 05:52:58]

Description was changed from

==========
Remove ScopedVector from media/audio/

base::ScopedVector is deprecated. This CL replaces ScopedVector
with std::vector<std::unique_ptr> in media/audio/.

BUG=554289
==========

to

==========
Remove ScopedVector from media/audio/

base::ScopedVector is deprecated. This CL replaces ScopedVector
with std::vector<std::unique_ptr> in media/audio/.

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Chandan, 2017-05-05 05:54:00]

The CQ bit was checked by c.padhi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 05:54:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 07:37:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 07:37:44]

Dry run: This issue passed the CQ dry run.

[Chandan, 2017-05-05 08:25:48]

c.padhi@samsung.com changed reviewers:
+ chcunningham@chromium.org, tommi@chromium.org

[Chandan, 2017-05-05 08:25:49]

PTAL. Thank you.

[tommi (sloooow) - chröme, 2017-05-05 08:58:43]

https://codereview.chromium.org/2867443002/diff/1/media/audio/audio_manager_b...
File media/audio/audio_manager_base.cc (right):

https://codereview.chromium.org/2867443002/diff/1/media/audio/audio_manager_b...
media/audio/audio_manager_base.cc:285: DispatcherParams* dispatcher_params =
dispatcher_params_ptr.get();
nit: just remove this variable and pass dispatcher_params_ptr.get() to
CompareByParams()

https://codereview.chromium.org/2867443002/diff/1/media/audio/audio_manager_b...
media/audio/audio_manager_base.cc:290: dispatcher_params_ptr.reset();
necessary? dispatcher_params_ptr is about to go out of scope

https://codereview.chromium.org/2867443002/diff/1/media/audio/audio_manager_b...
media/audio/audio_manager_base.cc:315: return
dispatcher_params->dispatcher->CreateStreamProxy();
If we're removing |dispatcher_params|, you'd have to change this to something
like:

return output_dispatchers_.back()->dispatcher->CreateStreamProxy();

[Chandan, 2017-05-05 09:19:32]

Please review. Thanks!

https://codereview.chromium.org/2867443002/diff/1/media/audio/audio_manager_b...
File media/audio/audio_manager_base.cc (right):

https://codereview.chromium.org/2867443002/diff/1/media/audio/audio_manager_b...
media/audio/audio_manager_base.cc:285: DispatcherParams* dispatcher_params =
dispatcher_params_ptr.get();
On 2017/05/05 08:58:43, tommi - chröme wrote:
> nit: just remove this variable and pass dispatcher_params_ptr.get() to
> CompareByParams()

Done.

https://codereview.chromium.org/2867443002/diff/1/media/audio/audio_manager_b...
media/audio/audio_manager_base.cc:290: dispatcher_params_ptr.reset();
On 2017/05/05 08:58:43, tommi - chröme wrote:
> necessary? dispatcher_params_ptr is about to go out of scope

Right. This can be dropped.

https://codereview.chromium.org/2867443002/diff/1/media/audio/audio_manager_b...
media/audio/audio_manager_base.cc:315: return
dispatcher_params->dispatcher->CreateStreamProxy();
On 2017/05/05 08:58:43, tommi - chröme wrote:
> If we're removing |dispatcher_params|, you'd have to change this to something
> like:
> 
> return output_dispatchers_.back()->dispatcher->CreateStreamProxy();

Intention was to avoid accessing the vector. Initial idea was to use back(). :)

[tommi (sloooow) - chröme, 2017-05-05 10:08:17]

lgtm

[Chandan, 2017-05-05 10:13:32]

The CQ bit was checked by c.padhi@samsung.com

[commit-bot: I haz the power, 2017-05-05 10:13:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 12:21:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493979212438850,
"parent_rev": "4451675d1f2349898d0a84cd25035296db70c6ea", "commit_rev":
"c0671c025e52b6072a6391c8e1cb8ffc4f13a24b"}

[commit-bot: I haz the power, 2017-05-05 12:21:14]

Description was changed from

==========
Remove ScopedVector from media/audio/

base::ScopedVector is deprecated. This CL replaces ScopedVector
with std::vector<std::unique_ptr> in media/audio/.

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove ScopedVector from media/audio/

base::ScopedVector is deprecated. This CL replaces ScopedVector
with std::vector<std::unique_ptr> in media/audio/.

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2867443002
Cr-Commit-Position: refs/heads/master@{#469627}
Committed:
https://chromium.googlesource.com/chromium/src/+/c0671c025e52b6072a6391c8e1cb...
==========

[commit-bot: I haz the power, 2017-05-05 12:21:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c0671c025e52b6072a6391c8e1cb...