Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2867373003: Add metrics for webapk update rate. (Closed)

Created:
3 years, 7 months ago by Yaron
Modified:
3 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add metrics for webapk update rate. Updates can fail for different reasons than install (e.g. signing issue). We expect all installs should be for the reason 'install failed' but need to verify. BUG=719955 Review-Url: https://codereview.chromium.org/2867373003 Cr-Commit-Position: refs/heads/master@{#470376} Committed: https://chromium.googlesource.com/chromium/src/+/884274a17f127dcd2f60f545262c873a7fbbdfee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Yaron
3 years, 7 months ago (2017-05-09 14:38:26 UTC) #2
Xi Han
lgtm
3 years, 7 months ago (2017-05-09 14:40:42 UTC) #3
Alexei Svitkine (slow)
lgtm
3 years, 7 months ago (2017-05-09 14:54:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867373003/1
3 years, 7 months ago (2017-05-09 14:58:33 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 17:57:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/884274a17f127dcd2f60f545262c...

Powered by Google App Engine
This is Rietveld 408576698