[wasm] Implement simd lowering for I8x16

[wasm] Implement simd lowering for I8x16

This change adds simd lowering support for:
I8x16Splat,I8x16ExtractLane,I8x16ReplaceLane,I8x16Neg,I8x16Shl,
I8x16ShrS,I8x16Add,I8x16AddSaturateS,I8x16Sub,I8x16SubSaturateS,
I8x16Mul,I8x16MinS,I8x16MaxS,I8x16ShrU,I8x16AddSaturateU,
I8x16SubSaturateU,I8x16MinU,I8x16MaxU,I8x16Eq,I8x16Ne,I8x16LtS,
I8x16LeS,I8x16LtU,I8x16LeU operations

BUG=

Review-Url: https://codereview.chromium.org/2867343002
Cr-Commit-Position: refs/heads/master@{#45331}
Committed: https://chromium.googlesource.com/v8/v8/+/64fb9441fd3cda3d2d45db28ebd28ebee429c9fd

[dusan.simicic, 2017-05-09 08:48:50]

dusan.simicic@imgtec.com changed reviewers:
+ aseemgarg@chromium.org, bbudge@chromium.org, bradnelson@chromium.org,
mtrofin@chromium.org, tebbi@google.com

[dusan.simicic, 2017-05-09 08:48:50]

PTAL

[Tobias Tebbi, 2017-05-09 10:37:17]

tebbi@chromium.org changed reviewers:
+ jarin@chromium.org, tebbi@chromium.org
- tebbi@google.com

[Tobias Tebbi, 2017-05-09 10:37:17]

+ jarin

[aseemgarg, 2017-05-09 20:01:24]

lgtm with nits. 
Thanks for jumping on this. I was working on the same patch.

https://codereview.chromium.org/2867343002/diff/1/src/compiler/simd-scalar-lo...
File src/compiler/simd-scalar-lowering.cc (right):

https://codereview.chromium.org/2867343002/diff/1/src/compiler/simd-scalar-lo...
src/compiler/simd-scalar-lowering.cc:26: static const int32_t kShift24 = 24;
rename to kShift8? I named these by type rather than value. Seems more
consistent with kNumLanes8

https://codereview.chromium.org/2867343002/diff/1/src/compiler/simd-scalar-lo...
src/compiler/simd-scalar-lowering.cc:473: MachineRepresentation phi_mach_rep;
rename to phi_rep?

[dusan.simicic, 2017-05-10 09:50:06]

https://codereview.chromium.org/2867343002/diff/1/src/compiler/simd-scalar-lo...
File src/compiler/simd-scalar-lowering.cc (right):

https://codereview.chromium.org/2867343002/diff/1/src/compiler/simd-scalar-lo...
src/compiler/simd-scalar-lowering.cc:26: static const int32_t kShift24 = 24;
On 2017/05/09 20:01:24, aseemgarg wrote:
> rename to kShift8? I named these by type rather than value. Seems more
> consistent with kNumLanes8

Done.

https://codereview.chromium.org/2867343002/diff/1/src/compiler/simd-scalar-lo...
src/compiler/simd-scalar-lowering.cc:473: MachineRepresentation phi_mach_rep;
On 2017/05/09 20:01:24, aseemgarg wrote:
> rename to phi_rep? 

Done.

[Mircea Trofin, 2017-05-15 20:20:36]

On 2017/05/10 09:50:06, dusan.simicic wrote:
>
https://codereview.chromium.org/2867343002/diff/1/src/compiler/simd-scalar-lo...
> File src/compiler/simd-scalar-lowering.cc (right):
> 
>
https://codereview.chromium.org/2867343002/diff/1/src/compiler/simd-scalar-lo...
> src/compiler/simd-scalar-lowering.cc:26: static const int32_t kShift24 = 24;
> On 2017/05/09 20:01:24, aseemgarg wrote:
> > rename to kShift8? I named these by type rather than value. Seems more
> > consistent with kNumLanes8
> 
> Done.
> 
>
https://codereview.chromium.org/2867343002/diff/1/src/compiler/simd-scalar-lo...
> src/compiler/simd-scalar-lowering.cc:473: MachineRepresentation phi_mach_rep;
> On 2017/05/09 20:01:24, aseemgarg wrote:
> > rename to phi_rep? 
> 
> Done.

Rubber stamp lgtm

[dusan.simicic, 2017-05-16 07:57:25]

The CQ bit was checked by dusan.simicic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 07:57:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 07:59:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 07:59:07]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/25956)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/41100)

[dusan.simicic, 2017-05-16 09:10:23]

The CQ bit was checked by dusan.simicic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 09:10:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 09:41:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 09:41:29]

Dry run: This issue passed the CQ dry run.

[dusan.simicic, 2017-05-16 10:53:07]

The CQ bit was checked by dusan.simicic@imgtec.com

[dusan.simicic, 2017-05-16 10:53:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
aseemgarg@chromium.org, mtrofin@chromium.org
Link to the patchset: https://codereview.chromium.org/2867343002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-16 10:53:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 10:54:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494931987301760,
"parent_rev": "6aaccd0f95c5c81b3540e4c7877b0552c12270a2", "commit_rev":
"64fb9441fd3cda3d2d45db28ebd28ebee429c9fd"}

[commit-bot: I haz the power, 2017-05-16 10:54:56]

Description was changed from

==========
[wasm] Implement simd lowering for I8x16

This change adds simd lowering support for:
I8x16Splat,I8x16ExtractLane,I8x16ReplaceLane,I8x16Neg,I8x16Shl,
I8x16ShrS,I8x16Add,I8x16AddSaturateS,I8x16Sub,I8x16SubSaturateS,
I8x16Mul,I8x16MinS,I8x16MaxS,I8x16ShrU,I8x16AddSaturateU,
I8x16SubSaturateU,I8x16MinU,I8x16MaxU,I8x16Eq,I8x16Ne,I8x16LtS,
I8x16LeS,I8x16LtU,I8x16LeU operations

BUG=
==========

to

==========
[wasm] Implement simd lowering for I8x16

This change adds simd lowering support for:
I8x16Splat,I8x16ExtractLane,I8x16ReplaceLane,I8x16Neg,I8x16Shl,
I8x16ShrS,I8x16Add,I8x16AddSaturateS,I8x16Sub,I8x16SubSaturateS,
I8x16Mul,I8x16MinS,I8x16MaxS,I8x16ShrU,I8x16AddSaturateU,
I8x16SubSaturateU,I8x16MinU,I8x16MaxU,I8x16Eq,I8x16Ne,I8x16LtS,
I8x16LeS,I8x16LtU,I8x16LeU operations

BUG=

Review-Url: https://codereview.chromium.org/2867343002
Cr-Commit-Position: refs/heads/master@{#45331}
Committed:
https://chromium.googlesource.com/v8/v8/+/64fb9441fd3cda3d2d45db28ebd28ebee42...
==========

[commit-bot: I haz the power, 2017-05-16 10:54:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/64fb9441fd3cda3d2d45db28ebd28ebee42...