Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2867333002: Revert "Separate preaload matching from MemoryCache" (Closed)

Created:
3 years, 7 months ago by yhirano
Modified:
3 years, 7 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, Yoav Weiss, gavinp+prerender_chromium.org, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Separate preaload matching from MemoryCache" This CL reverts [1] due to performance regressions. 1: https://chromium.googlesource.com/chromium/src/+/bb924e1897f5b4c67325dbfbdf2441e7f0686d53 BUG=695939, 719502 TBR=japhet@chromium.org Review-Url: https://codereview.chromium.org/2867333002 Cr-Commit-Position: refs/heads/master@{#470825} Committed: https://chromium.googlesource.com/chromium/src/+/97c0d877b1aff4ac84138c3eab71d994ead93b14

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Revert "Separate preaload matching from MemoryCache" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -382 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/HTMLLinkElement/link-and-subresource-test-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/preload/multiple-meta-csp.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/resources/srcset-helper.js View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/permissionclient/image-permissions-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/platform/loader/fetch/PreloadKey.h View 1 chunk +0 lines, -71 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h View 5 chunks +5 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 1 11 chunks +87 lines, -167 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp View 6 chunks +58 lines, -124 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 34 (29 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867333002/20001
3 years, 7 months ago (2017-05-10 07:27:58 UTC) #12
yhirano
3 years, 7 months ago (2017-05-10 07:39:43 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/449740)
3 years, 7 months ago (2017-05-10 09:07:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867333002/40001
3 years, 7 months ago (2017-05-11 04:23:50 UTC) #31
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 05:39:40 UTC) #34
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/97c0d877b1aff4ac84138c3eab71...

Powered by Google App Engine
This is Rietveld 408576698