ash/wm/workspace/phantom_window_controller.cc - Issue 286733002: [Refactor] Consolidate the logic for whether a widget can be activated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace/phantom_window_controller.cc

Issue 286733002: [Refactor] Consolidate the logic for whether a widget can be activated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/drag_window_controller.cc ('K') | « ash/wm/workspace/multi_window_resize_controller.cc ('k') | chrome/browser/chromeos/ui/idle_app_name_notification_view.cc » ('j') | ui/views/widget/widget.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/workspace/phantom_window_controller.cc

diff --git a/ash/wm/workspace/phantom_window_controller.cc b/ash/wm/workspace/phantom_window_controller.cc

index 23121c0c0e73f8b6903f919732802579a21012d5..ee2d458a3708fea3a98b9764b966f98fc25040ab 100644

--- a/ash/wm/workspace/phantom_window_controller.cc

+++ b/ash/wm/workspace/phantom_window_controller.cc

@@ -114,7 +114,6 @@ scoped_ptr<views::Widget> PhantomWindowController::CreatePhantomWidget(

// the phantom is visible.

params.parent = Shell::GetContainer(root_window,

kShellWindowId_ShelfContainer);

- params.can_activate = false;

params.keep_on_top = true;

params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;

phantom_widget->set_focus_on_creation(false);