ash/wm/drag_window_controller.cc - Issue 286733002: [Refactor] Consolidate the logic for whether a widget can be activated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/drag_window_controller.cc

Issue 286733002: [Refactor] Consolidate the logic for whether a widget can be activated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/wm/drag_window_controller.cc

diff --git a/ash/wm/drag_window_controller.cc b/ash/wm/drag_window_controller.cc

index eee66e46c5ed5db0a10c448b31353b9fd2f85c10..ecd2a5b6a99b21ee5dd3e2ff4171eca23deec56e 100644

--- a/ash/wm/drag_window_controller.cc

+++ b/ash/wm/drag_window_controller.cc

@@ -66,7 +66,7 @@ void DragWindowController::CreateDragWidget(const gfx::Rect& bounds) {

views::Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP);

params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;

params.parent = window_->parent();

- params.can_activate = false;

+ params.activatable = views::Widget::InitParams::ACTIVATABLE_NO;

sky 2014/05/14 14:06:30 How come you're explicit here, but in places like

pkotwicz 2014/05/14 15:24:38 There is no reason to be explicit here (or anywher

params.keep_on_top = true;

drag_widget_->set_focus_on_creation(false);

drag_widget_->Init(params);

« no previous file with comments | « ash/wm/dock/docked_window_layout_manager.cc ('k') | ash/wm/gestures/long_press_affordance_handler.cc » ('j') | ui/views/widget/widget.cc » ('J')