[Refactor] Consolidate the logic for whether a widget can be activated.

ash/wm/drag_window_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/drag_window_controller.h"
 
 #include "ash/shell_window_ids.h"
 #include "ash/wm/window_util.h"
 #include "ui/aura/client/screen_position_client.h"
 #include "ui/aura/window.h"
@@ skipping 48 matching lines @@
   ui::ScopedLayerAnimationSettings scoped_setter(layer->GetAnimator());
   layer->SetOpacity(opacity);
 }
 
 void DragWindowController::CreateDragWidget(const gfx::Rect& bounds) {
   DCHECK(!drag_widget_);
   drag_widget_ = new views::Widget;
   views::Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP);
   params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;
   params.parent = window_->parent();
-  params.can_activate = false;
+  params.activatable = views::Widget::InitParams::ACTIVATABLE_NO;

[sky, 2014/05/14 14:06:30]

How come you're explicit here, but in places like exit_warning_handler.cc you
aren't?

[pkotwicz, 2014/05/14 15:24:38]

There is no reason to be explicit here (or anywhere). I have fixed this in my
latest patch set.

   params.keep_on_top = true;
   drag_widget_->set_focus_on_creation(false);
   drag_widget_->Init(params);
   drag_widget_->SetVisibilityChangedAnimationsEnabled(false);
   drag_widget_->GetNativeWindow()->SetName("DragWindow");
   drag_widget_->GetNativeWindow()->set_id(kShellWindowId_PhantomWindow);
   // Show shadow for the dragging window.
   SetShadowType(drag_widget_->GetNativeWindow(),
                 ::wm::SHADOW_TYPE_RECTANGULAR);
   SetBoundsInternal(bounds);
@@ skipping 32 matching lines @@
   // Place the layer at (0, 0) of the DragWindowController's window.
   gfx::Rect layer_bounds = layer_owner_->root()->bounds();
   layer_bounds.set_origin(gfx::Point(0, 0));
   layer_owner_->root()->SetBounds(layer_bounds);
   layer_owner_->root()->SetVisible(false);
   // Detach it from the current container.
   layer_owner_->root()->parent()->Remove(layer_owner_->root());
 }
 
 }  // namespace ash