third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.h - Issue 2867293002: [LayoutNG] Compute baseline from fragment tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.h

Issue 2867293002: [LayoutNG] Compute baseline from fragment tree (Closed)

Patch Set: Cleanup Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.cc » ('j') | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.h

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.h

index 94aabeb011bb9c3ea66690219aa9ac7551610eff..386e44973b931d16a717cd4b10224893ade26d1c 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.h

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.h

@@ -9,6 +9,7 @@

#include "core/layout/ng/geometry/ng_logical_offset.h"

#include "core/layout/ng/inline/ng_line_height_metrics.h"

#include "core/layout/ng/ng_physical_fragment.h"

+#include "platform/fonts/FontBaseline.h"

namespace blink {

@@ -26,6 +27,9 @@ class CORE_EXPORT NGPhysicalLineBoxFragment final : public NGPhysicalFragment {

const NGLineHeightMetrics& Metrics() const { return metrics_; }

+ // Compute baseline for the specified baseline type.

+ LayoutUnit BaselinePosition(FontBaseline) const;

private:

Vector<RefPtr<NGPhysicalFragment>> children_;