third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.cc - Issue 2867293002: [LayoutNG] Compute baseline from fragment tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.cc

Issue 2867293002: [LayoutNG] Compute baseline from fragment tree (Closed)

Patch Set: Cleanup Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.h ('k') | third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.h » ('j') | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.cc

index 3e1b38f2f9f8cb826c84f07b8f64e94709c4d53c..ef10d5879c96aa1082af089953614eb7b9479092 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.cc

@@ -19,4 +19,11 @@ NGPhysicalLineBoxFragment::NGPhysicalLineBoxFragment(

children_.swap(children);

}

+LayoutUnit NGPhysicalLineBoxFragment::BaselinePosition(FontBaseline) const {

+ // TODO(kojii): Computing other baseline types than the used one is not

+ // implemented yet.

+ // TODO(kojii): We might need locale/script to look up OpenType BASE table.

+ return metrics_.ascent;

} // namespace blink