PaymentHandler: Replace GetAllManifests() with GetAllPaymentApps().

PaymentHandler: Replace GetAllManifests() with GetAllPaymentApps().

Use the new GetAllPaymentApps() instead of legacy GetAllManifests() in android.
Also, this CL removes unnecessary Manifest and Option classes in Bridge.

See the other CLs in this series:
  [1/2] http://crrev.com/2873683002 (Add GetAllPaymentApps())
  [2/2] http://crrev.com/2867273003 (This patch)

BUG=661608
Review-Url: https://codereview.chromium.org/2867273003
Cr-Commit-Position: refs/heads/master@{#471590}
Committed: https://chromium.googlesource.com/chromium/src/+/93b356ad256b7bff7db894592f1e49fd7aa9aeb3

[zino, 2017-05-09 16:30:14]

Description was changed from

==========
PaymentHandler: Replace GetAllManifests() with GetAllPaymentApps().

Use the new GetAllPaymentApps() instead of legacy GetAllManifests() in android.
Also, this CL removes unnecessary Manifest and Option classes in Bridge.

See the other CLs in this series:
  [1/3] http://crrev.com/ (Add GetAllPaymentApps())
  [2/3] http://crrev.com/ (This patch)
  [3/3] http://crrev.com/ (Remove GetAllManifests())

BUG=661608
==========

to

==========
PaymentHandler: Replace GetAllManifests() with GetAllPaymentApps().

Use the new GetAllPaymentApps() instead of legacy GetAllManifests() in android.
Also, this CL removes unnecessary Manifest and Option classes in Bridge.

See the other CLs in this series:
  [1/3] http://crrev.com/2867273003 (Add GetAllPaymentApps())
  [2/3] http://crrev.com/ (This patch)
  [3/3] http://crrev.com/ (Remove GetAllManifests())

BUG=661608
==========

[zino, 2017-05-09 16:30:32]

Description was changed from

==========
PaymentHandler: Replace GetAllManifests() with GetAllPaymentApps().

Use the new GetAllPaymentApps() instead of legacy GetAllManifests() in android.
Also, this CL removes unnecessary Manifest and Option classes in Bridge.

See the other CLs in this series:
  [1/3] http://crrev.com/2867273003 (Add GetAllPaymentApps())
  [2/3] http://crrev.com/ (This patch)
  [3/3] http://crrev.com/ (Remove GetAllManifests())

BUG=661608
==========

to

==========
PaymentHandler: Replace GetAllManifests() with GetAllPaymentApps().

Use the new GetAllPaymentApps() instead of legacy GetAllManifests() in android.
Also, this CL removes unnecessary Manifest and Option classes in Bridge.

See the other CLs in this series:
  [1/3] http://crrev.com/2867273003 (Add GetAllPaymentApps())
  [2/3] http://crrev.com/2867273003 (This patch)
  [3/3] http://crrev.com/ (Remove GetAllManifests())

BUG=661608
==========

[zino, 2017-05-09 16:31:21]

Description was changed from

==========
PaymentHandler: Replace GetAllManifests() with GetAllPaymentApps().

Use the new GetAllPaymentApps() instead of legacy GetAllManifests() in android.
Also, this CL removes unnecessary Manifest and Option classes in Bridge.

See the other CLs in this series:
  [1/3] http://crrev.com/2867273003 (Add GetAllPaymentApps())
  [2/3] http://crrev.com/2867273003 (This patch)
  [3/3] http://crrev.com/ (Remove GetAllManifests())

BUG=661608
==========

to

==========
PaymentHandler: Replace GetAllManifests() with GetAllPaymentApps().

Use the new GetAllPaymentApps() instead of legacy GetAllManifests() in android.
Also, this CL removes unnecessary Manifest and Option classes in Bridge.

See the other CLs in this series:
  [1/3] http://crrev.com/2873683002 (Add GetAllPaymentApps())
  [2/3] http://crrev.com/2867273003 (This patch)
  [3/3] http://crrev.com/ (Remove GetAllManifests())

BUG=661608
==========

[zino, 2017-05-09 16:52:28]

Description was changed from

==========
PaymentHandler: Replace GetAllManifests() with GetAllPaymentApps().

Use the new GetAllPaymentApps() instead of legacy GetAllManifests() in android.
Also, this CL removes unnecessary Manifest and Option classes in Bridge.

See the other CLs in this series:
  [1/3] http://crrev.com/2873683002 (Add GetAllPaymentApps())
  [2/3] http://crrev.com/2867273003 (This patch)
  [3/3] http://crrev.com/ (Remove GetAllManifests())

BUG=661608
==========

to

==========
PaymentHandler: Replace GetAllManifests() with GetAllPaymentApps().

Use the new GetAllPaymentApps() instead of legacy GetAllManifests() in android.
Also, this CL removes unnecessary Manifest and Option classes in Bridge.

See the other CLs in this series:
  [1/2] http://crrev.com/2873683002 (Add GetAllPaymentApps())
  [2/2] http://crrev.com/2867273003 (This patch)

BUG=661608
==========

[zino, 2017-05-09 16:55:17]

jinho.bang@samsung.com changed reviewers:
+ rouslan@chromium.org

[zino, 2017-05-09 16:56:29]

PTAL.

(I can remove GetAllManifests() and some legacy codes after this CL.)

Thanks.

[please use gerrit instead, 2017-05-09 18:54:36]

https://codereview.chromium.org/2867273003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java
(right):

https://codereview.chromium.org/2867273003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java:56:
callback.onInstrumentsReady(ServiceWorkerPaymentApp.this, mInstruments);
Collections.unmodifiableList(mInstruments)

https://codereview.chromium.org/2867273003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
(right):

https://codereview.chromium.org/2867273003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java:65:
instrumentId, label, new HashSet<String>(Arrays.asList(methodNames))));
Instead of creating an intermediate List and then throwing it away, please use a
"for (int i = 0..." loop over methodNames and add each method name to the set
directly.

https://codereview.chromium.org/2867273003/diff/1/chrome/browser/android/paym...
File chrome/browser/android/payments/service_worker_payment_app_bridge.cc
(right):

https://codereview.chromium.org/2867273003/diff/1/chrome/browser/android/paym...
chrome/browser/android/payments/service_worker_payment_app_bridge.cc:34: using
payments::mojom::PaymentMethodDataPtr;
Please move all the "using" statements inside of the anonymous namespace and
prepend the namespaces with ::. For example:

namespace {

using ::base::android::ToJavaArrayOfStrings;
...

[zino, 2017-05-10 18:08:32]

Patchset #2 (id:20001) has been deleted

[zino, 2017-05-10 18:28:39]

Thank you for review.

https://codereview.chromium.org/2867273003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java
(right):

https://codereview.chromium.org/2867273003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java:56:
callback.onInstrumentsReady(ServiceWorkerPaymentApp.this, mInstruments);
On 2017/05/09 18:54:36, ಠ_ಠ wrote:
> Collections.unmodifiableList(mInstruments)

Done.

https://codereview.chromium.org/2867273003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
(right):

https://codereview.chromium.org/2867273003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java:65:
instrumentId, label, new HashSet<String>(Arrays.asList(methodNames))));
On 2017/05/09 18:54:36, ಠ_ಠ wrote:
> Instead of creating an intermediate List and then throwing it away, please use
a
> "for (int i = 0..." loop over methodNames and add each method name to the set
> directly.

Done.

https://codereview.chromium.org/2867273003/diff/1/chrome/browser/android/paym...
File chrome/browser/android/payments/service_worker_payment_app_bridge.cc
(right):

https://codereview.chromium.org/2867273003/diff/1/chrome/browser/android/paym...
chrome/browser/android/payments/service_worker_payment_app_bridge.cc:34: using
payments::mojom::PaymentMethodDataPtr;
On 2017/05/09 18:54:36, ಠ_ಠ wrote:
> Please move all the "using" statements inside of the anonymous namespace and
> prepend the namespaces with ::. For example:
> 
> namespace {
> 
> using ::base::android::ToJavaArrayOfStrings;
> ...

Done.

[please use gerrit instead, 2017-05-10 18:30:31]

https://codereview.chromium.org/2867273003/diff/1/chrome/browser/android/paym...
File chrome/browser/android/payments/service_worker_payment_app_bridge.cc
(right):

https://codereview.chromium.org/2867273003/diff/1/chrome/browser/android/paym...
chrome/browser/android/payments/service_worker_payment_app_bridge.cc:34: using
payments::mojom::PaymentMethodDataPtr;
On 2017/05/10 18:28:39, zino wrote:
> On 2017/05/09 18:54:36, ಠ_ಠ wrote:
> > Please move all the "using" statements inside of the anonymous namespace and
> > prepend the namespaces with ::. For example:
> > 
> > namespace {
> > 
> > using ::base::android::ToJavaArrayOfStrings;
> > ...
> 
> Done.

You seem to have missed this one.

https://codereview.chromium.org/2867273003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
(right):

https://codereview.chromium.org/2867273003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java:63:
HashSet<String> methodNames = new HashSet<String>();
Set<String> methodNames = new HashSet<>();

[zino, 2017-05-11 01:34:29]

Thank you for review.

https://codereview.chromium.org/2867273003/diff/1/chrome/browser/android/paym...
File chrome/browser/android/payments/service_worker_payment_app_bridge.cc
(right):

https://codereview.chromium.org/2867273003/diff/1/chrome/browser/android/paym...
chrome/browser/android/payments/service_worker_payment_app_bridge.cc:34: using
payments::mojom::PaymentMethodDataPtr;
On 2017/05/10 18:30:31, ಠ_ಠ wrote:
> On 2017/05/10 18:28:39, zino wrote:
> > On 2017/05/09 18:54:36, ಠ_ಠ wrote:
> > > Please move all the "using" statements inside of the anonymous namespace
and
> > > prepend the namespaces with ::. For example:
> > > 
> > > namespace {
> > > 
> > > using ::base::android::ToJavaArrayOfStrings;
> > > ...
> > 
> > Done.
> 
> You seem to have missed this one.

Oh.. Sorry.

Done.

https://codereview.chromium.org/2867273003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
(right):

https://codereview.chromium.org/2867273003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java:63:
HashSet<String> methodNames = new HashSet<String>();
On 2017/05/10 18:30:31, ಠ_ಠ wrote:
> Set<String> methodNames = new HashSet<>();

Done.

[please use gerrit instead, 2017-05-11 15:14:10]

lgtm

[zino, 2017-05-13 08:00:21]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-05-13 08:00:21]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2867273003/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2017-05-13 08:00:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[zino, 2017-05-13 12:35:13]

The CQ bit was unchecked by jinho.bang@samsung.com

[zino, 2017-05-13 12:35:28]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2017-05-13 12:35:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 16:51:18]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494678928146530,
"parent_rev": "441ca70d0885c3cefafce97b8f72922ee05111e7", "commit_rev":
"93b356ad256b7bff7db894592f1e49fd7aa9aeb3"}

[commit-bot: I haz the power, 2017-05-13 16:51:30]

Description was changed from

==========
PaymentHandler: Replace GetAllManifests() with GetAllPaymentApps().

Use the new GetAllPaymentApps() instead of legacy GetAllManifests() in android.
Also, this CL removes unnecessary Manifest and Option classes in Bridge.

See the other CLs in this series:
  [1/2] http://crrev.com/2873683002 (Add GetAllPaymentApps())
  [2/2] http://crrev.com/2867273003 (This patch)

BUG=661608
==========

to

==========
PaymentHandler: Replace GetAllManifests() with GetAllPaymentApps().

Use the new GetAllPaymentApps() instead of legacy GetAllManifests() in android.
Also, this CL removes unnecessary Manifest and Option classes in Bridge.

See the other CLs in this series:
  [1/2] http://crrev.com/2873683002 (Add GetAllPaymentApps())
  [2/2] http://crrev.com/2867273003 (This patch)

BUG=661608

Review-Url: https://codereview.chromium.org/2867273003
Cr-Commit-Position: refs/heads/master@{#471590}
Committed:
https://chromium.googlesource.com/chromium/src/+/93b356ad256b7bff7db894592f1e...
==========

[commit-bot: I haz the power, 2017-05-13 16:51:32]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/93b356ad256b7bff7db894592f1e...