Add additional automated Daydream controller functionality

Add additional automated Daydream controller functionality

Adds automated/emulated Daydream controller features such as:
- Scrolling up/down
- View recentering
- Pointer movement

and updates the controller test library to a version that supports this.
This new library *should* support anything a real controller can do,
although additional changes may be made in the future to make it more
user-friendly, e.g. allowing the use of either angles or quaternions for
functions instead of only supporting one, seemingly at random.

Also adds a VR Shell e2e test for scrolling using this new functionality.

BUG=713342
Review-Url: https://codereview.chromium.org/2867243002
Cr-Commit-Position: refs/heads/master@{#471352}
Committed: https://chromium.googlesource.com/chromium/src/+/fc093d3e84762bfd20224adf0e73b49d2ad34247

[bsheedy, 2017-05-08 23:34:47]

bsheedy@chromium.org changed reviewers:
+ bajones@chromium.org, mthiesse@chromium.org

[bsheedy, 2017-05-08 23:34:47]

+bajones@ for third_party/gvr-android-sdk OWNERS

+mthiesse@ for eventual javatests OWNERS (I'll wait for the vr_shell test OWNERS
change to land so we don't have to bother other reviewers for this)

https://codereview.chromium.org/2867243002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java
(right):

https://codereview.chromium.org/2867243002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java:58:
public void recenterView(float x, float y, float z, float w) {
I'm not personally aware of any use case where we care about where the
controller was pointing when recentering occurs. AFAIK, we only care if it was
properly recentered - if this is the case, I can remove this function.

[tiborg, 2017-05-09 14:15:39]

Description was changed from

==========
Add additional automated Daydream controller functionality

Adds automated/emulated Daydream controller features such as:
- Scrolling up/down
- View recentering
- Pointer movement

and updates the controller test library to a version that supports this.
This new library *should* support anything a real controller can do,
although additional changes may be made in the future to make it more
user-friendly, e.g. allowing the use of either angles or quaternions for
functions instead of only supporting one, seemingly at random.

Also adds a VR Shell e2e test for scrolling using this new functionality.

BUG=713342
==========

to

==========
Add additional automated Daydream controller functionality

Adds automated/emulated Daydream controller features such as:
- Scrolling up/down
- View recentering
- Pointer movement

and updates the controller test library to a version that supports this.
This new library *should* support anything a real controller can do,
although additional changes may be made in the future to make it more
user-friendly, e.g. allowing the use of either angles or quaternions for
functions instead of only supporting one, seemingly at random.

Also adds a VR Shell e2e test for scrolling using this new functionality.

BUG=713342
==========

[mthiesse, 2017-05-09 17:52:03]

lgtm

https://codereview.chromium.org/2867243002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java
(right):

https://codereview.chromium.org/2867243002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java:58:
public void recenterView(float x, float y, float z, float w) {
On 2017/05/08 23:34:47, bsheedy wrote:
> I'm not personally aware of any use case where we care about where the
> controller was pointing when recentering occurs. AFAIK, we only care if it was
> properly recentered - if this is the case, I can remove this function.

Right, we don't currently care where we're pointing when re-centering occurs.
Probably best to simplify this for now and add it back later if we need it.

https://codereview.chromium.org/2867243002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java:63:
SystemClock.sleep(500);
Somewhat disappointing that the controller testing API is so full of sleeps, but
doesn't look like there's anything we can do about that...

https://codereview.chromium.org/2867243002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
(right):

https://codereview.chromium.org/2867243002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java:203:
loadUrl("chrome://version", PAGE_LOAD_TIMEOUT_S);
Not sure how safe it is to assume chrome://version is scrollable...

If you want to use a chrome:// page, maybe chrome://credits is a better choice?

[bsheedy, 2017-05-09 18:22:44]

https://codereview.chromium.org/2867243002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java
(right):

https://codereview.chromium.org/2867243002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java:58:
public void recenterView(float x, float y, float z, float w) {
On 2017/05/09 17:52:03, mthiesse wrote:
> On 2017/05/08 23:34:47, bsheedy wrote:
> > I'm not personally aware of any use case where we care about where the
> > controller was pointing when recentering occurs. AFAIK, we only care if it
was
> > properly recentered - if this is the case, I can remove this function.
> 
> Right, we don't currently care where we're pointing when re-centering occurs.
> Probably best to simplify this for now and add it back later if we need it.

Done.

https://codereview.chromium.org/2867243002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
(right):

https://codereview.chromium.org/2867243002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java:203:
loadUrl("chrome://version", PAGE_LOAD_TIMEOUT_S);
On 2017/05/09 17:52:03, mthiesse wrote:
> Not sure how safe it is to assume chrome://version is scrollable...
> 
> If you want to use a chrome:// page, maybe chrome://credits is a better
choice?

Done.

[bajones, 2017-05-12 17:03:09]

lgtm

[bsheedy, 2017-05-12 17:03:49]

The CQ bit was checked by bsheedy@chromium.org

[bsheedy, 2017-05-12 17:03:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org
Link to the patchset: https://codereview.chromium.org/2867243002/#ps20001
(title: "Address mthiesse@ comments")

[commit-bot: I haz the power, 2017-05-12 17:05:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 17:36:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494608629343530,
"parent_rev": "ae192fde12e7fba4ac2d8f027037d10c3d0f22a4", "commit_rev":
"fc093d3e84762bfd20224adf0e73b49d2ad34247"}

[commit-bot: I haz the power, 2017-05-12 17:36:52]

Description was changed from

==========
Add additional automated Daydream controller functionality

Adds automated/emulated Daydream controller features such as:
- Scrolling up/down
- View recentering
- Pointer movement

and updates the controller test library to a version that supports this.
This new library *should* support anything a real controller can do,
although additional changes may be made in the future to make it more
user-friendly, e.g. allowing the use of either angles or quaternions for
functions instead of only supporting one, seemingly at random.

Also adds a VR Shell e2e test for scrolling using this new functionality.

BUG=713342
==========

to

==========
Add additional automated Daydream controller functionality

Adds automated/emulated Daydream controller features such as:
- Scrolling up/down
- View recentering
- Pointer movement

and updates the controller test library to a version that supports this.
This new library *should* support anything a real controller can do,
although additional changes may be made in the future to make it more
user-friendly, e.g. allowing the use of either angles or quaternions for
functions instead of only supporting one, seemingly at random.

Also adds a VR Shell e2e test for scrolling using this new functionality.

BUG=713342

Review-Url: https://codereview.chromium.org/2867243002
Cr-Commit-Position: refs/heads/master@{#471352}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc093d3e84762bfd20224adf0e73...
==========

[commit-bot: I haz the power, 2017-05-12 17:36:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fc093d3e84762bfd20224adf0e73...