Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: chrome/test/data/webui/settings/languages_page_tests.js

Issue 2867213002: Fix CrSettingsLanguagesPageTest dialog flake (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/languages_page_tests.js
diff --git a/chrome/test/data/webui/settings/languages_page_tests.js b/chrome/test/data/webui/settings/languages_page_tests.js
index 8bccfad534280762cb873ba0299faaa60d106d9c..b7a5f6ae524c951fd146131c14a70b4c0667689a 100644
--- a/chrome/test/data/webui/settings/languages_page_tests.js
+++ b/chrome/test/data/webui/settings/languages_page_tests.js
@@ -108,9 +108,13 @@ cr.define('languages_page_tests', function() {
});
// After every test, check that the dialog is removed from the DOM.
- teardown(function() {
+ teardown(function(done) {
+ // Flush the DOM, then wait for the |restamp| to take effect.
Polymer.dom.flush();
- assertEquals(null, languagesPage.$$('settings-add-languages-dialog'));
+ setTimeout(function() {
dpapad 2017/05/09 01:14:29 Nit (optional): Perhaps it would be more robust to
michaelpg 2017/05/16 00:03:44 The MutationObserver you suggested in the bug work
+ assertEquals(null, languagesPage.$$('settings-add-languages-dialog'));
+ done();
+ });
});
test('cancel', function() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698