Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 2867213002: Fix CrSettingsLanguagesPageTest dialog flake (Closed)

Created:
3 years, 7 months ago by michaelpg
Modified:
3 years, 7 months ago
Reviewers:
dpapad
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix CrSettingsLanguagesPageTest dialog flake BUG=641400 R=dpapad@chromium.org Review-Url: https://codereview.chromium.org/2867213002 Cr-Commit-Position: refs/heads/master@{#472682} Committed: https://chromium.googlesource.com/chromium/src/+/12ddbd73d25fefda658eb70e10bf94418ee9b51d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use MutationObserver #

Total comments: 4

Patch Set 3 : parens #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -8 lines) Patch
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/settings/languages_page_tests.js View 1 2 4 chunks +34 lines, -8 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
dpapad
LGTM https://codereview.chromium.org/2867213002/diff/1/chrome/test/data/webui/settings/languages_page_tests.js File chrome/test/data/webui/settings/languages_page_tests.js (right): https://codereview.chromium.org/2867213002/diff/1/chrome/test/data/webui/settings/languages_page_tests.js#newcode114 chrome/test/data/webui/settings/languages_page_tests.js:114: setTimeout(function() { Nit (optional): Perhaps it would be ...
3 years, 7 months ago (2017-05-09 01:14:29 UTC) #1
michaelpg
PTAnotherL at MutationObserver. If this looks good it may be something we should use in ...
3 years, 7 months ago (2017-05-16 00:03:44 UTC) #2
dpapad
LGTM https://codereview.chromium.org/2867213002/diff/20001/chrome/test/data/webui/settings/languages_page_tests.js File chrome/test/data/webui/settings/languages_page_tests.js (right): https://codereview.chromium.org/2867213002/diff/20001/chrome/test/data/webui/settings/languages_page_tests.js#newcode87 chrome/test/data/webui/settings/languages_page_tests.js:87: var onMutation = function(mutations, observer) { Is this ...
3 years, 7 months ago (2017-05-16 00:19:43 UTC) #5
michaelpg
https://codereview.chromium.org/2867213002/diff/20001/chrome/test/data/webui/settings/languages_page_tests.js File chrome/test/data/webui/settings/languages_page_tests.js (right): https://codereview.chromium.org/2867213002/diff/20001/chrome/test/data/webui/settings/languages_page_tests.js#newcode87 chrome/test/data/webui/settings/languages_page_tests.js:87: var onMutation = function(mutations, observer) { On 2017/05/16 00:19:43, ...
3 years, 7 months ago (2017-05-16 19:57:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867213002/40001
3 years, 7 months ago (2017-05-16 19:59:23 UTC) #11
dpapad
On 2017/05/16 at 19:57:39, michaelpg wrote: > https://codereview.chromium.org/2867213002/diff/20001/chrome/test/data/webui/settings/languages_page_tests.js > File chrome/test/data/webui/settings/languages_page_tests.js (right): > > https://codereview.chromium.org/2867213002/diff/20001/chrome/test/data/webui/settings/languages_page_tests.js#newcode87 ...
3 years, 7 months ago (2017-05-16 20:52:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/455173)
3 years, 7 months ago (2017-05-16 23:35:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867213002/40001
3 years, 7 months ago (2017-05-17 19:59:09 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/447558)
3 years, 7 months ago (2017-05-17 22:45:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867213002/40001
3 years, 7 months ago (2017-05-17 23:45:44 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 05:21:43 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/12ddbd73d25fefda658eb70e10bf...

Powered by Google App Engine
This is Rietveld 408576698