Linux native notifications: fix Tsan failure in NotifyAndCloseFormat

Linux native notifications: fix Tsan failure in NotifyAndCloseFormat

Gmock cannot have EXPECT_CALL's intersparsed with actual calls in a
multithreaded environment.  This CL changes
NotificationPlatformBridgeLinuxTest to specify all EXPECT_CALL's
before creating the task runner thread.

BUG=719485
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2867203002
Cr-Commit-Position: refs/heads/master@{#470197}
Committed: https://chromium.googlesource.com/chromium/src/+/cec16ad195ac43f821606e8e17e04e32d2539867

[Tom (Use chromium acct), 2017-05-08 21:27:26]

thestig ptal

The alternative to this would be to get rid of BrowserThreadBundle like we had
originally:
https://codereview.chromium.org/2849003002/#ps20001

I kind of like kepping BrowserThreadBundle though, because it means the test
code would be more similar to production code.  wdyt?

[Lei Zhang, 2017-05-08 21:52:34]

lgtm

I like keeping BrowserThreadBundle.

[Tom (Use chromium acct), 2017-05-08 21:55:24]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-05-08 21:56:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:20:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494280524301570, "parent_rev":
"65bb182d82588d3c7e8723c4bd45c3219d121cb4", "commit_rev":
"cec16ad195ac43f821606e8e17e04e32d2539867"}

[commit-bot: I haz the power, 2017-05-09 04:20:23]

Description was changed from

==========
Linux native notifications: fix Tsan failure in NotifyAndCloseFormat

Gmock cannot have EXPECT_CALL's intersparsed with actual calls in a
multithreaded environment.  This CL changes
NotificationPlatformBridgeLinuxTest to specify all EXPECT_CALL's
before creating the task runner thread.

BUG=719485
R=thestig@chromium.org
==========

to

==========
Linux native notifications: fix Tsan failure in NotifyAndCloseFormat

Gmock cannot have EXPECT_CALL's intersparsed with actual calls in a
multithreaded environment.  This CL changes
NotificationPlatformBridgeLinuxTest to specify all EXPECT_CALL's
before creating the task runner thread.

BUG=719485
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2867203002
Cr-Commit-Position: refs/heads/master@{#470197}
Committed:
https://chromium.googlesource.com/chromium/src/+/cec16ad195ac43f821606e8e17e0...
==========

[commit-bot: I haz the power, 2017-05-09 04:20:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cec16ad195ac43f821606e8e17e0...