Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2867173002: Install HostSharedBitmapManager to cc::Display created by MusDisplayProvider (Closed)

Created:
3 years, 7 months ago by Alex Z.
Modified:
3 years, 7 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Install HostSharedBitmapManager to cc::Display created by MusDisplayProvider MusDisplayProvider passes the current HostSharedBitmapManager to cc::Display when CreateDisplay is called. MusDisplayProvider should use HostSharedBitmapManager for completeness now that HostSharedBitmapManager is componentized. BUG=712198 Review-Url: https://codereview.chromium.org/2867173002 Cr-Commit-Position: refs/heads/master@{#470162} Committed: https://chromium.googlesource.com/chromium/src/+/411212290c406a1537d51d57ca624aa274b411fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M services/ui/surfaces/mus_display_provider.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Alex Z.
PTAL.
3 years, 7 months ago (2017-05-08 20:50:23 UTC) #4
Fady Samuel
LGTM. It would be nice to move components/display_compositor into components/viz/display_compositor, and use the viz namespace? ...
3 years, 7 months ago (2017-05-08 20:51:55 UTC) #5
Alex Z.
On 2017/05/08 20:51:55, Fady Samuel wrote: > LGTM. It would be nice to move components/display_compositor ...
3 years, 7 months ago (2017-05-08 20:55:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867173002/1
3 years, 7 months ago (2017-05-08 23:48:08 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 03:47:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/411212290c406a1537d51d57ca62...

Powered by Google App Engine
This is Rietveld 408576698