Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issue 2867113002: Update expectations for instance creations to match front_end. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update expectations for instance creations to match front_end. Front_end wants to annotate instance creations like this: new /*@typeArgs=Foo*/ bar(); Whereas the existing tests use this style: /*@typeArgs=Foo*/ new bar(); It's easier to modify the analyzer code to use the front_end style than to update the front_end to use the analyzer style, and besides, I think the front_end style makes more sense. I've also added a boolean to front_end_inference_test.dart to allow expectations to be updated more easily in the future. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/fcd22c2c89fa53ff1c0712c790524cf7765a9332

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -94 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 3 chunks +10 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_downwards_with_constraint.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_argument_not_assignable.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_const.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_const_with_upper_bound.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_downwards_from_constructor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_factory_calls_constructor.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_named.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_named_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_redirecting.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_redirecting_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_inference_f_bounded.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_reverse_type_parameters.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_too_many_positional_arguments.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/downward_inference_miscellaneous.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_async_await.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_for_each.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_inside_top_level.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_generic_constructor_arguments_empty_list.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_generic_constructor_arguments_infer_downwards.dart View 1 chunk +10 lines, -8 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_instance_creations_infer_downwards.dart View 4 chunks +24 lines, -24 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_yield_yield_star.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_async_conditional.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_async_conditional_2.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_2.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_3.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_4.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_iterable_and_future.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_5.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/instantiate_to_bounds_invoke_constructor_no_bound.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/local_constructor_from_arguments.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_constructor_call_implicit_type_param.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-08 17:52:03 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-08 17:54:42 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-08 18:02:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fcd22c2c89fa53ff1c0712c790524cf7765a9332 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698