Update expectations for instance creations to match front_end.

pkg/analyzer/test/src/task/strong/front_end_inference_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
@@ skipping 14 matching lines @@
 
 main() {
   // Use a group() wrapper to specify the timeout.
   group('front_end_inference_test', () {
     defineReflectiveSuite(() {
       defineReflectiveTests(RunFrontEndInferenceTest);
     });
   }, timeout: new Timeout(const Duration(seconds: 60)));
 }
 
+/// Set this to `true` to cause expectation comments to be updated.
+const bool fixProblems = false;
+
 @reflectiveTest
 class RunFrontEndInferenceTest {
   test_run() async {
     String pkgPath = _findPkgRoot();
     String fePath = pathos.join(pkgPath, 'front_end', 'testcases', 'inference');
     List<File> dartFiles = new Directory(fePath)
         .listSync()
         .where((entry) => entry is File && entry.path.endsWith('.dart'))
         .map((entry) => entry as File)
         .toList();
@@ skipping 47 matching lines @@
     await validation.loadExpectations(uri);
 
     provider.newFile(path, code);
 
     AnalysisResult result = await driver.getResult(path);
     result.unit.accept(new _InstrumentationVisitor(validation, uri));
 
     validation.finish();
 
     if (validation.hasProblems) {
-      return validation.problemsAsString;
+      if (fixProblems) {
+        validation.fixSource(uri);
+        return null;
+      } else {
+        return validation.problemsAsString;
+      }
     } else {
       return null;
     }
   }
 }
 
 /**
  * Instance of [InstrumentationValue] describing a [DartType].
  */
 class _InstrumentationValueForType extends fasta.InstrumentationValue {
@@ skipping 119 matching lines @@
       }
     }
   }
 
   visitInstanceCreationExpression(InstanceCreationExpression node) {
     super.visitInstanceCreationExpression(node);
     DartType type = node.staticType;
     if (type is InterfaceType) {
       if (type.typeParameters.isNotEmpty &&
           node.constructorName.type.typeArguments == null) {
-        _recordTypeArguments(node.offset, type.typeArguments);
+        _recordTypeArguments(node.constructorName.offset, type.typeArguments);
       }
     }
   }
 
   visitListLiteral(ListLiteral node) {
     super.visitListLiteral(node);
     if (node.typeArguments == null) {
       DartType type = node.staticType;
       if (type is InterfaceType) {
         _recordTypeArguments(node.offset, type.typeArguments);
@@ skipping 49 matching lines @@
   void _recordType(int offset, DartType type) {
     _instrumentation.record(
         uri, offset, 'type', new _InstrumentationValueForType(type));
   }
 
   void _recordTypeArguments(int offset, List<DartType> typeArguments) {
     _instrumentation.record(uri, offset, 'typeArgs',
         new _InstrumentationValueForTypeArgs(typeArguments));
   }
 }