Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: components/offline_pages/core/downloads/download_notifying_observer_unittest.cc

Issue 2867103006: [Offline pages] Rename REMOVED to USER_CANCELED and add better foot note descriptions for histogram… (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/downloads/download_notifying_observer_unittest.cc
diff --git a/components/offline_pages/core/downloads/download_notifying_observer_unittest.cc b/components/offline_pages/core/downloads/download_notifying_observer_unittest.cc
index 6db87708702286214aeeb9cd393658b01052247f..48af1b047b1642efb47a5adbafdab9638857fa56 100644
--- a/components/offline_pages/core/downloads/download_notifying_observer_unittest.cc
+++ b/components/offline_pages/core/downloads/download_notifying_observer_unittest.cc
@@ -211,8 +211,8 @@ TEST_F(DownloadNotifyingObserverTest, OnCompletedSuccess) {
TEST_F(DownloadNotifyingObserverTest, OnCompletedCanceled) {
SavePageRequest request(kTestOfflineId, GURL(kTestUrl), kTestClientId,
kTestCreationTime, kTestUserRequested);
- observer()->OnCompleted(request,
- RequestNotifier::BackgroundSavePageResult::REMOVED);
+ observer()->OnCompleted(
+ request, RequestNotifier::BackgroundSavePageResult::USER_CANCELED);
EXPECT_EQ(LastNotificationType::DOWNLOAD_CANCELED,
notifier()->last_notification_type());
EXPECT_EQ(kTestGuid, notifier()->download_item()->guid);
« no previous file with comments | « components/offline_pages/core/downloads/download_notifying_observer.cc ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698